[production/AQM.v7] More EE2 compliance for removal of -nowarn in non-debug builds

ufs-community / ccpp-physics

UFS fork for CCPP

Other

4 stars 33 forks source link

[production/AQM.v7] More EE2 compliance for removal of -nowarn in non-debug builds #170

Closed BrianCurtis-NOAA closed 7 months ago

BrianCurtis-NOAA commented 7 months ago

Taking care of warnings after removing '-nowarn' from non-debug builds

Most variables were unused and unset, so switching from OUT to INOUT fixed the warnings.

This is not a permanent solution, as a permanent solution will come into the develop branch later.

Qingfu-Liu commented 7 months ago

This PR#170 is similar to PR#169, and the code in this PR is using the old directory structure for the CCPP physics. Also, The variables errmsg and errflg in physics/CONV/progsigma_calc.f90 have been removed in the new code.

BrianCurtis-NOAA commented 7 months ago

This PR#170 is similar to PR#169, and the code in this PR is using the old directory structure for the CCPP physics. Also, The variables errmsg and errflg in physics/CONV/progsigma_calc.f90 have been removed in the new code.

Thanks @Qingfu-Liu , this code was frozen a while ago, so I need to work with the frozen pieces. It's good to know it's fixed in dev!

BrianCurtis-NOAA commented 7 months ago

@climbfuji This is ready for merge. Are you OK with these changes?

BrianCurtis-NOAA commented 7 months ago

Please merge too, since I do not have those permissions here.