incorporate csawMG update and pass both intel and GNU RT tests

[AnningCheng-NOAA]

ajor updated CSAW deep convective scheme: considering sigma vertical veriantion and reduction on fluxes instead of tendency etc. • Regression tests are performed on the new version of CSAW for GNU and intel compilers Here is a EMail from Don describe the changes: On Thu, Oct 24, 2019 at 3:01 PM Donald Dazlich - NOAA Affiliate [donald.dazlich@noaa.gov](mailto:donald.dazlich@noaa.gov) wrote: Hi Moorthi, Anning, Dave and I have been using the GFS version of CS to redo our implementation of AW more completely and consistently. Now, you will find that the fix_form implemetation of the tendencies match up very closely with the traditional form. Also you will notice that it is the fluxes for each cloud type (and the downdraft) that are saved and the reduction is done on the fluxes, not the tendency computed from the flux divergence. Since sigma is a function of height the latter approach is incorrect. I’ve also dimensioned several cloud type variables nctp+1 - the nctp+1 slot has downdraft output. Another addition is the sorting of the lamdas after they are computed for all cloud types, then computing the sigma. This approach is detailed in a manuscript Dave is working on. Also, sigma is not applied to the inputs to the downdraft routine, but to the outputs, which are now mass fluxes not tendencies. The water and thermodynamic budgets remain satisfied now. I’ve attached my version below. It should be pretty close to your version with regards to the interface so you shouldn’t have to do much work with it. Regards, Don

[AnningCheng-NOAA]

Qingfu, nice catch! and fixed.

On Thu, Feb 15, 2024 at 11:33 AM Qingfu Liu @.***> wrote:

@.**** commented on this pull request.

In physics/CONV/Chikira_Sugiyama/cs_conv.F90 https://github.com/ufs-community/ccpp-physics/pull/171#discussion_r1491297802 :

@@ -3841,64 +4083,66 @@ SUBROUTINE CUMFXR1 & ! Tracer mass fixer ! 2: mass fixer is applied, total mass never change through cumulus scheme ! e.g. CO2 INTEGER ISTS, IENS

• REAL(kind_phys) sigmai (IM,KMAX+1,NCTP), sigma(IM,KMAX+1) !!DDsigma cloud updraft fraction

Variables sigmai and sigma are not used in SUBROUTINE CUMFXR1, so variables sigmai, sigma and nctp can be removed from SUBROUTINE CUMFXR1

— Reply to this email directly, view it on GitHub https://github.com/ufs-community/ccpp-physics/pull/171#pullrequestreview-1883309910, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIOK4NPVCUOCHWUJOU3YTY2G7AVCNFSM6AAAAABDGXNNRKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOBTGMYDSOJRGA . You are receiving this because you authored the thread.Message ID: @.***>

[AnningCheng-NOAA]

Sorry for those empty lines, coming from debugging or from the old version of the code.

[grantfirl]

@AnningCheng-NOAA I'm going to try to clean up some of the whitespace and documentation changes so that the PR only shows actually meaningful changes. I may open another PR to make it easier to track and ask for you to review.

[AnningCheng-NOAA]

sure. Thank you! @Grant Firl @.***>

On Wed, Mar 6, 2024 at 1:19 PM Grant Firl @.***> wrote:

@AnningCheng-NOAA https://github.com/AnningCheng-NOAA I'm going to try to clean up some of the whitespace and documentation changes so that the PR only shows actually meaningful changes. I may open another PR to make it easier to track and ask for you to review.

— Reply to this email directly, view it on GitHub https://github.com/ufs-community/ccpp-physics/pull/171#issuecomment-1981516236, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALQPMIL5QYY23TIINMKMAWLYW5M2DAVCNFSM6AAAAABDGXNNRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBRGUYTMMRTGY . You are receiving this because you were mentioned.Message ID: @.***>

[grantfirl]

Closed in favor of https://github.com/ufs-community/ccpp-physics/pull/181 that started from the top of ufs/dev and has fewer whitespace/comment changes that make it difficult to review and understand the changes.