search

ufs-community / ccpp-physics

UFS fork for CCPP
Other
4 stars 33 forks source link

On ufs-community/ccpp-physics Issue #172 #173

Closed ShanSunNOAA closed 7 months ago

ShanSunNOAA commented 7 months ago

-- 'tisfc' is no longer modified by the atmospheric model, i.e., allowing the ice model to determine the ice temperature over both sea ice and lake ice; -- Changing tisfc from intent(inout) to intent(in).

yangfanglin commented 7 months ago

Shan, could you please attach to this PR the slides you and/or Lydia made to illustrate the problem the PR is addressing ?

ShanSunNOAA commented 7 months ago

This issue is identified here. The output from my experiment is here.

grantfirl commented 7 months ago

@ShanSunNOAA Have you run UFS regression tests with this change? Do you expect any baseline changes?

ShanSunNOAA commented 7 months ago

I haven't run any regression tests. I'd be happy to do so, when it is my turn for the PR. I expect most baselines, if not all, will change.

grantfirl commented 7 months ago

I haven't run any regression tests. I'd be happy to do so, when it is my turn for the PR. I expect most baselines, if not all, will change.

UFS code managers expect RTs to be run before it is your turn in the queue. Their job is to verify that the code is behaving as you claim, so you need to show proof of running RTs on Hera/Derecho/Hercules via a log that shows which tests fail and those failures need to be expected/explainable from your code changes.

I've started PRs for fv3atm and ufs-weather-model (https://github.com/NOAA-EMC/fv3atm/pull/783, https://github.com/ufs-community/ufs-weather-model/pull/2137). I'll fill out the templates and ask for help if I need it.

ShanSunNOAA commented 7 months ago

Sounds good. Thanks for the info and the heads up.

grantfirl commented 7 months ago

@ShanSunNOAA Can you please pull in the latest ufs/dev branch code into your PR branch? Let me know if you need help with this.

FernandoAndrade-NOAA commented 7 months ago

Testing for #2137 has completed successfully, please continue with the merge process.