ufs-community / ccpp-physics

UFS fork for CCPP
Other
4 stars 33 forks source link

[production/RRFS.v1] physics updates for RRFS.v1 code freeze #176

Closed haiqinli closed 7 months ago

haiqinli commented 7 months ago

This PR includes the following updates: 1). MYNN updates; 2). RUC LSM updates (https://github.com/ufs-community/ccpp-physics/pull/163); 3). GF updates for humidity DA; restore scale-awareness in the 1st hour; suppress weak radar reflectivity over water; 4). smoke plume rise updates for stability on WCOSS2; 5). GWD updates to reduce the high 10m wind speed bias.

MatthewPyle-NOAA commented 7 months ago

@grantfirl Does more need to be done before this PR will be reviewed/merged? Still trying to understand the process with the production release branch. Thanks!

grantfirl commented 7 months ago

@MatthewPyle-NOAA We just need to review it and @haiqinli needs to upload the test_changes.list file in https://github.com/ufs-community/ufs-weather-model/pull/2147, assuming that we don't request changes. I'm also working on getting https://github.com/ufs-community/ccpp-physics/pull/147 and https://github.com/ufs-community/ccpp-physics/pull/159 in

MatthewPyle-NOAA commented 7 months ago

Thanks for the explanation, @grantfirl

grantfirl commented 7 months ago

@haiqinli Looks fine with the exception of some minor typo-like things. Once you address those, I'll approve. Please remember to commit the test_changes.list file that is generated now in the ufs-weather-model/tests directory for that PR.

grantfirl commented 7 months ago

This contains the changes from https://github.com/ufs-community/ccpp-physics/pull/163.

jkbk2004 commented 7 months ago

tests are done at https://github.com/ufs-community/ufs-weather-model/pull/2147. @grantfirl can you merge this pr?

jkbk2004 commented 7 months ago

@MatthewPyle-NOAA You may go ahead to merge this pr if you have permission.

MatthewPyle-NOAA commented 7 months ago

@jkbk2004 I don't have that permission, at least not yet.

climbfuji commented 7 months ago

I'll merge it for you

jkbk2004 commented 7 months ago

I'll merge it for you

Thanks! @climbfuji

grantfirl commented 7 months ago

@climbfuji Thanks. I got a late start this morning.