search

ufs-community / ccpp-physics

UFS fork for CCPP
Other
4 stars 33 forks source link

[production/RRFS.v1] Update MYNN PBL & Smoke for RRFS.v1 #180

Closed haiqinli closed 6 months ago

haiqinli commented 7 months ago
  1. Update the MYNN PBL scheme for the RRFS.v1 code freeze.
  2. Update the Smoke modules for the RRFS.v1.
  3. Include the PR https://github.com/ufs-community/ccpp-physics/pull/186.
grantfirl commented 7 months ago

@haiqinli Please merge in the latest production/RRFS.v1 branch.

grantfirl commented 6 months ago

@haiqinli What are your thoughts on combining https://github.com/ufs-community/ccpp-physics/pull/186 into this? Also, are you going to recreate the fv3atm PR?

haiqinli commented 6 months ago

@grantfirl Yes, it is fine with me that combining https://github.com/ufs-community/ccpp-physics/pull/186 into this. Yes, I will recreate the fv3atm PR when the regression test is done. If we decide to combine https://github.com/ufs-community/ccpp-physics/pull/186 into this, I will merge it and redo the regression test.

grantfirl commented 6 months ago

@grantfirl Yes, it is fine with me that combining #186 into this. Yes, I will recreate the fv3atm PR when the regression test is done. If we decide to combine #186 into this, I will merge it and redo the regression test.

OK, let's do that. Please let me know if you need help. Also, when you create the fv3atm PR, be sure to include the changes in https://github.com/NOAA-EMC/fv3atm/pull/801.

haiqinli commented 6 months ago

@grantfirl Sure, I am starting to merge Jili's PR, and will let you know if I need your help. Thanks for coordinating these efforts.

grantfirl commented 6 months ago

@haiqinli Merge looks good. I'll close #186.

haiqinli commented 6 months ago

@grantfirl Yes, https://github.com/ufs-community/ccpp-physics/pull/186 has been merged. Thanks.

jkbk2004 commented 6 months ago

@MatthewPyle-NOAA @grantfirl @dustinswales tests are done at https://github.com/ufs-community/ufs-weather-model/pull/2170. can you merge this pr?