search

ufs-community / ccpp-physics

UFS fork for CCPP
Other
3 stars 32 forks source link

[production/RRFS.v1] fix zero cloud fraction for RRFS ensemble members #186

Closed JiliDong-NOAA closed 4 months ago

JiliDong-NOAA commented 4 months ago

This PR will address zero cloud fraction issue for RRFS ensemble members using GFS PBL and G-F convection by adding SGS cloud to ccpp SDF and changing conv_cf_opt to Xu-Randall for convective cloud fraction computation for those members.

The change to ccpp-physics is to add conv_cf_opt as an input namelist parameter for runtime switch (conv_cf_opt=1 for GFS PBL members).

ccpp-physics issue: https://github.com/ufs-community/ccpp-physics/issues/185

Several tests for a single case (init 2023/05/10/06Z) have been performed by:

  1. using progcld_thompson_wsm6 in radiation_clouds.f
  2. using sgscloud_radpre with CB
  3. using sgscloud_radpre with XR

Here are total/low/medium/high cloud fractions and downward short wave radiation flux at surface: cldfra_comparison_f24.pptx cldfra_comparison_f36.pptx dswrfsfc.pptx

JiliDong-NOAA commented 4 months ago

could we have @yangfanglin @joeolson42 @JongilHan66 @haiqinli @RuiyuSun @AnningCheng-NOAA @ericaligo-NOAA to review this PR?

JiliDong-NOAA commented 4 months ago

Approved, although do you want to combine this with #180? It would make testing/approval/merge faster.

sounds good to me. The related FV3 PR is: https://github.com/NOAA-EMC/fv3atm/pull/801

grantfirl commented 4 months ago

This PR was combined into #180.