ufs-community / ccpp-physics

UFS fork for CCPP
Other
4 stars 33 forks source link

Compiler warnings/remarks #200

Open DusanJovic-NOAA opened 5 months ago

DusanJovic-NOAA commented 5 months ago

When we build ccpp-physics as a ufs-weather-model sub module we are required to have 0 warnings. Following is a list of warnings/remarks from a ufs-weather-model build on Hera:

ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(1909): remark #5140: Unrecognized directive
!dir$ prefervector
------------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(2110): remark #5140: Unrecognized directive
!dir$ prefervector
------------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(2147): remark #5140: Unrecognized directive
!dir$ prefervector
------------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(2185): remark #5140: Unrecognized directive
!dir$ prefervector
------------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(2203): remark #5140: Unrecognized directive
!dir$ prefervector
------------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(3906): remark #5140: Unrecognized directive
!dir$ prefervector
------------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(3924): remark #5082: Directive ignored - Syntax error, found INTEGER_CONSTANT '0' when expecting one of: ( <END-OF-STATEMENT> ; =
!dir$ unroll 0
-------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(3926): remark #5140: Unrecognized directive
!dir$ prefervector
------------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(4825): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [U10]
                             u10,fv,                                 & !o
-----------------------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Lake/CLM/clm_lake.f90(4825): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [FV]
                             u10,fv,                                 & !o
---------------------------------^
ufs-weather-model/FV3/ccpp/physics/physics/smoke_dust/dep_dry_mod_emerson.F90(23): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [SETTLING_FLUX]
               settling_flag,drydep_flux,settling_flux,dbg_opt,           &
-----------------------------------------^
ufs-weather-model/FV3/ccpp/physics/physics/CONV/Chikira_Sugiyama/cs_conv.F90(165): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [CLCN]
                          CNV_DQLDT,CLCN,CNV_FICE,CNV_NDROP,CNV_NICE,       &
------------------------------------^
ufs-weather-model/FV3/ccpp/physics/physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90(9981): remark #7713: This statement function has not been used.   [R]
  real (kind=kind_phys) :: r,x
---------------------------^
ufs-weather-model/FV3/ccpp/physics/physics/GWD/cires_ugwpv1_oro.F90(14): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [ZLWB]
                      zobl, zlwb, zogw, tau_ogw, dudt_ogw, dvdt_ogw,      &
----------------------------^

All warnings must be fixed, and it would also be nice to eliminate the remarks as well.