ufs-community / ccpp-physics

UFS fork for CCPP

Other

3 stars 32 forks source link

sfcsub.F - Fix the setting of model landmask when interpolating GLDAS data #202

Closed GeorgeGayno-NOAA closed 2 months ago

GeorgeGayno-NOAA commented 2 months ago

The model land mask was set incorrectly when interpolating GLDAS data. See

199 for a description of the problem and solution.

Fixes #199.

Related PRs:

https://github.com/NOAA-EMC/fv3atm/pull/827
https://github.com/ufs-community/ufs-weather-model/pull/2253

GeorgeGayno-NOAA commented 2 months ago

Recommend @HelinWei-NOAA as one of the reviewers.

grantfirl commented 2 months ago

@GeorgeGayno-NOAA Since this doesn't change regression test baselines, I'd like to combine this PR with others for streamlining the UFS merge process. Is this OK with you?

GeorgeGayno-NOAA commented 2 months ago

@GeorgeGayno-NOAA Since this doesn't change regression test baselines, I'd like to combine this PR with others for streamlining the UFS merge process. Is this OK with you?

Sure.

grantfirl commented 2 months ago

Combined into #205