search

ufs-community / ccpp-physics

UFS fork for CCPP
Other
4 stars 33 forks source link

Add explicit alpha_fd coefficient to TOFD in drag_suite.F90 #210

Closed mdtoyNOAA closed 4 months ago

mdtoyNOAA commented 4 months ago

Description

Added explicit 'alpha_fd' coefficient to drag_suite.F90 which corresponds directly to 'alpha' coefficient in Beljaars et al. (QJRMS, 2004), which by default is 12.0. The coefficient will be a runtime namelist option, and can control the strength of the turbulent orographic form drag (TOFD). Note that the runtime results are bit-for-bit identical to those of the previous version unless a value other than alpha_fd = 12.0 in the namelist. Regression tests have been performed on Hera with the Intel and Gnu compilers. The tests involving ugwpv1 all passed for both intel and gnu compilers, however, some of the other gnu tests failed. These tests also failed with the previous commit, so failures don't appear to have to do with the code changes in this PR.

Issues

This PR addresses ccpp-physics Issue #208.

mdtoyNOAA commented 4 months ago

Looks fine once small metadata change is completed.

Thank you. @grantfirl This draft PR is being folded in to PR #207, but I see you've made the same comment in that thread, so all should be well.

grantfirl commented 4 months ago

This is to be combined into #207