search

ufs-community / ccpp-physics

UFS fork for CCPP
Other
4 stars 33 forks source link

The final physics update PR to RRFS.v1 #211

Closed haiqinli closed 2 months ago

haiqinli commented 4 months ago

This is the final physics updates PR to RRFS.v1, and it includes some minor physics bug fixies of RUC LSM, FMS and smoke/dust.

jordanschnell commented 4 months ago

@haiqinli @dustinswales - can I make this change (above for precip_factor) directly or does Haiqin need to do it?

grantfirl commented 4 months ago

@haiqinli @dustinswales - can I make this change (above for precip_factor) directly or does Haiqin need to do it?

It depends on whether you have push access to Haiqin's fork. If he adds your GitHub user as a collaborator on his fork of ccpp-physics, then you should have push permissions and can make commits.

haiqinli commented 4 months ago

@jordanschnell I am back, and I can update the PR to include your changes.

haiqinli commented 4 months ago

@grantfirl Some smoke code updates will come next Monday. Let's hold this PR a couple of days. Thanks.

grantfirl commented 3 months ago

@haiqinli Do you still want to hold this, or should it be scheduled on the merge queue?

haiqinli commented 3 months ago

@haiqinli Do you still want to hold this, or should it be scheduled on the merge queue?

@grantfirl I am updating this PR, and we can schedule it on the queue. Thanks.

jkbk2004 commented 2 months ago

@grantfirl @dustinswales @MatthewPyle-NOAA Tests are done at https://github.com/ufs-community/ufs-weather-model/pull/2298. Can you merge this pr?

MatthewPyle-NOAA commented 2 months ago

@jkbk2004 Ability to merge looks to be held up by an old block.