search

ufs-community / ccpp-physics

UFS fork for CCPP
Other
4 stars 34 forks source link

Test updated RRTMGP cloud optics #33

Open RobertPincus opened 1 year ago

RobertPincus commented 1 year ago

Description

One of the radiation codes used in CCPP physics, RRTMGP, just updated the cloud optics to correct an error in the spectral ordering. This introduces changes of a few W/m2 in thick clouds. The updated data comes in a standalone file read at run time.

Solution

Forecasts should be run to determine whether this correction changes forecast skill for better or worse. This will require updating the dtc/ccpp branch of the RRTMGP repository (last updated by Sam Trahan), using the updated code to build the UFS, and changing the name of the data file used for the SW cloud optics (the old file no longer being present).

yangfanglin commented 1 year ago

@RobertPincus thanks for the update. Please let @ChunxiZhang-NOAA and @dustinswales know if you need any help for committing this update. We need to make sure to remove the old data file from all platforms and install the new one. I will ask @Qingfu-Liu to run experiments to test the impact after the code is committed if no others are planning to test the impact in the UFS global model.

RobertPincus commented 1 year ago

@yangfanglin I have not done any implementation on the UFS side so would indeed need the help of @dustinswales and/or @ChunxiZhang-NOAA to get this pulled into UFS

dustinswales commented 1 year ago

@RobertPincus Thanks for the heads up. I intend to open a PR for the outstanding refactoring work and then will incorporate these changes. @yangfanglin @ChunxiZhang-NOAA I'm hesitant about folding this in with the RRTMGP refactoring, just because that PR will be a bit "heavy" and contains baseline changes from some bug fixes to the SW surface flux coupling.

Any objections to addressing this issue after the refactoring PR goes in? (Which will be opened imminently)

yangfanglin commented 1 year ago

Dustin, you plan makes a lot of sense

-- Fanglin Yang, Ph.D. Chief, Model Physics Group Modeling and Data Assimilation Branch

NOAA/NWS/NCEP Environmental Modeling Center

https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/ https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/

ChunxiZhang-NOAA commented 1 year ago

@dustinswales No objections. Since there are not many ccpp-physics PRs in queue, no problem to have two PRs at all.

RobertPincus commented 1 year ago

@dustinswales None here either, especially as the refactoring won't change answers and the new data will.