ufs-community / regional_workflow

THIS REPOSITORY IS NOW DEPRECATED; SEE UFS SRW APP FOR CURRENT CODE
https://github.com/ufs-community/ufs-srweather-app
Other
10 stars 86 forks source link

Function "set_known_sys_dir" no longer exists in workflow #700

Closed mkavulich closed 2 years ago

mkavulich commented 2 years ago

Description

PR #666 (go figure) introduced a bug to the workflow generation script that produces some "command not found" error messages due to the "set_known_sys_dir" function no longer existing. It appears as if this is a harmless bug, as these function calls have been superseded by machine-specific logic elsewhere in the code due to that PR, but the calls to this non-existant function should be removed nonetheless to avoid confusion and potential future errors.

Steps to Reproduce

Run any experiment generation script on any machine for any valid config.sh file (without the "EXTRN_MDL_SYSBASEDIR_ICS" and/or "EXTRN_MDL_SYSBASEDIR_LBCS" variables set), observe the following line(s) in the output:

./set_extrn_mdl_params.sh: line 21: set_known_sys_dir: command not found
./set_extrn_mdl_params.sh: line 23: set_known_sys_dir: command not found