search

ufs-community / regional_workflow

THIS REPOSITORY IS NOW DEPRECATED; SEE UFS SRW APP FOR CURRENT CODE
https://github.com/ufs-community/ufs-srweather-app
Other
10 stars 87 forks source link

Update workflow python scripts #760

Closed chan-hoo closed 2 years ago

chan-hoo commented 2 years ago

DESCRIPTION OF CHANGES:

The workflow python scripts, config_defaults.yaml and setup.py, are updated to avoid conflict with the recent change by the PR #744.

TESTS CONDUCTED:

gsketefian commented 2 years ago

@chan-hoo When you ran the test, did you use generate_FV3LAM_wflow.py or generate_FV3LAM_wflow.sh (hopefully the former)?

danielabdi-noaa commented 2 years ago

@chan-hoo This is already part of #747 but I guess we can go with this one. Could you please take a look lines 1044 and below in setup.py it since it looks like there are changes I made there that could be missing in this PR.

chan-hoo commented 2 years ago

@chan-hoo When you ran the test, did you use generate_FV3LAM_wflow.py or generate_FV3LAM_wflow.sh (hopefully the former)?

@gsketefian, yes. I used 'generate_FV3LAM_wflow.py'.

chan-hoo commented 2 years ago

@chan-hoo This is already part of #747 but I guess we can go with this one. Could you please take a look lines 1044 and below in setup.py it since it looks like there are changes I made there that could be missing in this PR.

@danielabdi-noaa, Updated! Yes, without this change, the python script doesn't work correctly. If your PR is merged earlier than this PR, I'll close this PR.

danielabdi-noaa commented 2 years ago

@chan-hoo I just missed that you had a duplicate if statement at line 1044 in setup.py -- probably merging issue?

chan-hoo commented 2 years ago

@danielabdi-noaa, I'll fix this in my another PR.

danielabdi-noaa commented 2 years ago

@chan-hoo Ok sorry could't catch it in time -- only noticed it when trying to merge to mine. Could you also include all other changes (like new Grid that was added) since then. My PR should only have the new github actions unittest file (python_unittests.yaml), all other changes are related to the py workflow.