ufs-community / regional_workflow

THIS REPOSITORY IS NOW DEPRECATED; SEE UFS SRW APP FOR CURRENT CODE
https://github.com/ufs-community/ufs-srweather-app
Other
10 stars 86 forks source link

[develop]: Remove shell workflow. #764

Closed danielabdi-noaa closed 2 years ago

danielabdi-noaa commented 2 years ago

DESCRIPTION OF CHANGES:

This PR removes the shell workflow. Almost all of the duplicate files under ush/ are removed, choosing either the shell or python version. Two files still need both versions since it turned out to be difficult to use the python versions in job scripts without regional_workflow environment activated there. The PR will make updates much easier because there is only one workflow generation path to worry about.

TESTS CONDUCTED:

I have run tests successfully on HERA, ORION and JET. The set of tests are taken from a recent run using the shell workflow generation path done in PR #744 slighltly modified to use the new "custom_ESG/GFDLgrid" names.

Out of 56 tests

these are the failures where the reason is mentioned in brackets

HERA 0 failures

ORION 1 failure

nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR (run_fcst segfault)

JET only 5 failures which is a lot of improvement since last time I tried.

MET_ensemble_verification (run_gridstatvx_)
MET_verification (run_gridstatvx)
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR (make_lbcs)
nco_ensemble (run_fcst)
pregen_grid_orog_sfc_climo (run_fcst)

DEPENDENCIES:

None

DOCUMENTATION:

None

ISSUE (optional):

None

CONTRIBUTORS (optional):

@christinaholtNOAA @venitahagerty

JeffBeck-NOAA commented 2 years ago

WE2E using the config.community.sh file succeeded on Hera.