This PR modifies the script get_WE2Etest_names_subdirs_descs.sh that creates the CSV file containing test information the columns for relative cost and time step (DT_ATMOS). This allows users to have a better idea of what the cost of each test is (the relative cost is defined such that 1 unit represents the cost of running a single 6-hour forecast on the RRFS_CONUS_25km grid).
Other related changes:
Add the flag generate_csv_file to the run_WE2E_tests.sh script to allow users to skip the CSV file generation step (since it can take a while).
Use arguments for the function set_predef_grid_params() so that it can be called not just from the experiment generation scripts but also others (in this case from get_WE2Etest_names_subdirs_descs.sh). Necessary for this PR.
Move some constants (NH0, NH3, NH4) from config_defaults.sh to constants.sh to make it easier to access them.
Place the contents of constants.sh at the start of each experiment's var_defns.sh so that these constants are available to the j-jobs and ex-scripts when var_defns.sh is sourced.
Use variable valid_vals_BOOLEAN in many more places (which allows many other valid_vals_... variables in valid_param_vals.sh and setup.sh to be removed).
Several other bug fixes.
TESTS CONDUCTED:
The following tests (with results) were conducted on Hera. There were only three (previously existing) failures.
DESCRIPTION OF CHANGES:
This PR modifies the script
get_WE2Etest_names_subdirs_descs.sh
that creates the CSV file containing test information the columns for relative cost and time step (DT_ATMOS
). This allows users to have a better idea of what the cost of each test is (the relative cost is defined such that 1 unit represents the cost of running a single 6-hour forecast on theRRFS_CONUS_25km
grid).Other related changes:
generate_csv_file
to therun_WE2E_tests.sh
script to allow users to skip the CSV file generation step (since it can take a while).set_predef_grid_params()
so that it can be called not just from the experiment generation scripts but also others (in this case fromget_WE2Etest_names_subdirs_descs.sh
). Necessary for this PR.NH0
,NH3
,NH4
) fromconfig_defaults.sh
toconstants.sh
to make it easier to access them.constants.sh
at the start of each experiment'svar_defns.sh
so that these constants are available to the j-jobs and ex-scripts whenvar_defns.sh
is sourced.valid_vals_BOOLEAN
in many more places (which allows many othervalid_vals_...
variables invalid_param_vals.sh
andsetup.sh
to be removed).TESTS CONDUCTED:
The following tests (with results) were conducted on Hera. There were only three (previously existing) failures.
DOCUMENTATION:
Documentation is updated via PR #278 in the
ufs-srweather-app
repo.