search

ufs-community / regional_workflow

THIS REPOSITORY IS NOW DEPRECATED; SEE UFS SRW APP FOR CURRENT CODE
https://github.com/ufs-community/ufs-srweather-app
Other
10 stars 86 forks source link

Adding new E2E non-compact grids #786

Closed EdwardSnyder-NOAA closed 2 years ago

EdwardSnyder-NOAA commented 2 years ago

DESCRIPTION OF CHANGES:

Added 6 new non-compact grids for testing. See the list below. These tests will be included in the upcoming SRW v2 Release. These changes will be merged into the develop branch as well.

TESTS CONDUCTED:

The first four tests listed above ran on Orion successfully. The last two, RRFS_CONUS_3km, grids ran successfully on Parallel Works AWS cluster.

DEPENDENCIES:

No Dependencies.

DOCUMENTATION:

No documentation changes are needed.

ISSUE (optional):

CONTRIBUTORS (optional):

gsketefian commented 2 years ago

@JeffBeck-NOAA @BenjaminBlake-NOAA @RatkoVasic-NOAA I advised @EdwardSnyder-NOAA to add the six tests config.grid_RRFS_CONUS_[3|13|25]km_ics_FV3GFS_lbcs_FV3GFS_suite_[RRFS_v1beta|HRRR] to the release branch (and eventually to develop) because the officially supported grids for the release are the RRFS_CONUS_[25|13|3]km grids, not the compact ones RRFS_CONUS_[25|13|3]km, but currently both branches contain tests only on the compact grids for these two suites. What do you think?

JeffBeck-NOAA commented 2 years ago

Agree with this. Thanks, @gsketefian, @EdwardSnyder-NOAA!

gsketefian commented 2 years ago

@EdwardSnyder-NOAA I'm just waiting to hear back from EMC (@BenjaminBlake-NOAA or @RatkoVasic-NOAA) and if they're ok with it, we can approve and merge.

gsketefian commented 2 years ago

@EdwardSnyder-NOAA Go ahead and merge after you can confirm that the 3km tests passed. Thanks for creating this PR.

gsketefian commented 2 years ago

@EdwardSnyder-NOAA And please fix up the documentation section of the PR message. Currently says "Documentation might need to be" and that's all.

EdwardSnyder-NOAA commented 2 years ago

@gsketefian 3- I've updated the documentation section.

The 3km tests ran successfully on the Parallel Works AWS cluster.