search

ufs-community / regional_workflow

THIS REPOSITORY IS NOW DEPRECATED; SEE UFS SRW APP FOR CURRENT CODE
https://github.com/ufs-community/ufs-srweather-app
Other
10 stars 86 forks source link

Bugfix with machine file wrapper. #823

Closed danielabdi-noaa closed 2 years ago

danielabdi-noaa commented 2 years ago

DESCRIPTION OF CHANGES:

Machine file wrapper source_machine_file.sh uses save/restore_shell_opts but those are not defined when it is called from load_module_run_task and launch_FV3LAM_wflow because bash utilities are sourced after the machine file. A simple change in order of sourcing these files should fix it. After this fix, i was able to use set -e for all scripts.

TESTS CONDUCTED:

Run one test on hera manually, will run automated test later.

venitahagerty commented 2 years ago

Machine: hera Compiler: intel Job: WE Repo location: /scratch1/BMC/zrtrr/rrfs_ci/autoci/pr/1025384393/20220812212017/ufs-srweather-app Build was Successful Rocoto jobs started Long term tracking will be done on 9 experiments If test failed, please make changes and add the following label back: ci-hera-intel-WE Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_GSMGFS_lbcs_GSMGFS_suite_GFS_v15p2 Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2 Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_RAP_suite_HRRR Experiment Succeeded on hera: nco_grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_HRRR Experiment Succeeded on hera: grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v16 Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR Experiment Succeeded on hera: grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_RRFS_v1beta All experiments completed