search

ufs-community / ufs-mrweather-app

UFS Medium-Range Weather Application
Other
23 stars 23 forks source link

Updated UFSATM interface #191

Closed uturuncoglu closed 4 years ago

uturuncoglu commented 4 years ago

This PR aims to update buildlib in UFSATM interface to resolve the build issue related with the radiation_aerosol.f file. The more information can be found in https://github.com/ufs-community/ufs-mrweather-app/issues/169

The External.cfg contains following items;

climbfuji commented 4 years ago

I am not familiar with the details of the build system (buildlib) but based on the reports that this has resolved the build issue (#169), I recommend we accept it.

Has this really solved the build issue? The comments in #169 seem to be more like the issue still being present. I got the same build issues when I tried the app with @uturuncoglu 's branch (from which this PR comes) on Cheyenne yesterday.

ligiabernardet commented 4 years ago

Here is why I understood this solved the problem. from Ufuk on 9/9 slack https://ufs-r2o-coupled.slack.com/archives/C018JL2JN69: we are thinking that the buildlib in UFSATM interface causing the build error and i was testing old version of it and it seems working without any problem. So, we are plaining to put old buildlib to new interface. What do you think about it? It won’t affect the new features that is provided by the interface because we will still use the new buildnml but it will solve the build issue.

On Thu, Sep 10, 2020 at 12:54 PM Dom Heinzeller notifications@github.com wrote:

@climbfuji approved this pull request.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ufs-community/ufs-mrweather-app/pull/191#pullrequestreview-486222839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7WQAWMQWOP3DD7IEAMCK3SFEOGLANCNFSM4RFRTYUA .

climbfuji commented 4 years ago

Here is why I understood this solved the problem. from Ufuk on 9/9 slack https://ufs-r2o-coupled.slack.com/archives/C018JL2JN69: we are thinking that the buildlib in UFSATM interface causing the build error and i was testing old version of it and it seems working without any problem. So, we are plaining to put old buildlib to new interface. What do you think about it? It won’t affect the new features that is provided by the interface because we will still use the new buildnml but it will solve the build issue. …

Ok, I was not aware of this, sorry. Will merge now.

llpcarson commented 4 years ago

But now the model is hanging at run-time, right? May or may not be related to the build changes? Will try a test now...

On Thu, Sep 10, 2020 at 1:13 PM Dom Heinzeller notifications@github.com wrote:

Here is why I understood this solved the problem. from Ufuk on 9/9 slack https://ufs-r2o-coupled.slack.com/archives/C018JL2JN69: we are thinking that the buildlib in UFSATM interface causing the build error and i was testing old version of it and it seems working without any problem. So, we are plaining to put old buildlib to new interface. What do you think about it? It won’t affect the new features that is provided by the interface because we will still use the new buildnml but it will solve the build issue. … <#m1880360635522145090>

Ok, I was not aware of this, sorry. Will merge now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ufs-community/ufs-mrweather-app/pull/191#issuecomment-690647524, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2OWIXDSFQS6GTHHU4KL3LSFEQPHANCNFSM4RFRTYUA .

ligiabernardet commented 4 years ago

Correct. Perhaps the build issue is solved (thanks for testing) but the hanging problem still exists.

On Thu, Sep 10, 2020 at 1:25 PM Laurie Carson notifications@github.com wrote:

But now the model is hanging at run-time, right? May or may not be related to the build changes? Will try a test now...

On Thu, Sep 10, 2020 at 1:13 PM Dom Heinzeller notifications@github.com wrote:

Here is why I understood this solved the problem. from Ufuk on 9/9 slack https://ufs-r2o-coupled.slack.com/archives/C018JL2JN69: we are thinking that the buildlib in UFSATM interface causing the build error and i was testing old version of it and it seems working without any problem. So, we are plaining to put old buildlib to new interface. What do you think about it? It won’t affect the new features that is provided by the interface because we will still use the new buildnml but it will solve the build issue. … <#m1880360635522145090>

Ok, I was not aware of this, sorry. Will merge now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/ufs-community/ufs-mrweather-app/pull/191#issuecomment-690647524 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AB2OWIXDSFQS6GTHHU4KL3LSFEQPHANCNFSM4RFRTYUA

.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/ufs-community/ufs-mrweather-app/pull/191#issuecomment-690659494, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7WQATIFUK6UG74R4VVGGDSFER23ANCNFSM4RFRTYUA .

climbfuji commented 4 years ago

Correct. Perhaps the build issue is solved (thanks for testing) but the hanging problem still exists. On Thu, Sep 10, 2020 at 1:25 PM Laurie Carson notifications@github.com wrote: …

Are we using threading? If yes: Can we test compiling without OpenMP, or even easier, run with one OpenMP thread only, and see if this solves the problem?