ufs-community / ufs-srweather-app

UFS Short-Range Weather Application
Other
55 stars 116 forks source link

[production/AQM.v7] Enhancing EE2 compliance for the AQMv7 package #1034

Closed JianpingHuang-NOAA closed 6 months ago

JianpingHuang-NOAA commented 6 months ago

DESCRIPTION OF CHANGES:

1) Removed "nowarn" flags in the ufs-weather-model's makefile and fixed "warning" issues related to CCPP

2) Deleted unused scripts and utilities

3) Fixed the hardcoded issues with AQM_UTIL and UFS_UTILS

Type of change

TESTS CONDUCTED:

CHECKLIST

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

BrianCurtis-NOAA commented 6 months ago

@chan-hoo it looks like checks are blocking merge here, do you normally bypass that requirement to merge?

chan-hoo commented 6 months ago

@BrianCurtis-NOAA, uhm... strange. I didn't change anything. I have no idea what happens.

chan-hoo commented 6 months ago

@BrianCurtis-NOAA, I have not met this error before. Do you know how to fix this?

BrianCurtis-NOAA commented 6 months ago

Looks like it's mandatory a codeowner reviews, i'll have to add myself to codeowners soon. Can you please @chan-hoo

MichaelLueken commented 6 months ago

@BrianCurtis-NOAA and @chan-hoo, you should be safe to bypass branch protections for this failure. A new documentation test has been added. The current documentation subdirectory in develop is docs, rather than the NCO compliant doc. This is why the test is failing (it is looking for contents in docs, rather than doc). This will be addressed in PR #1018.

Please feel free to merge this PR.