ufs-community / ufs-srweather-app

UFS Short-Range Weather Application
Other
55 stars 116 forks source link

[develop] Fix sample script and WE2E test for AQM #1040

Closed chan-hoo closed 5 months ago

chan-hoo commented 6 months ago

DESCRIPTION OF CHANGES:

Type of change

TESTS CONDUCTED:

ISSUE:

Fixes issue mentioned in #1019

CHECKLIST

CONTRIBUTORS:

@MichaelLueken @RatkoVasic-NOAA

MichaelLueken commented 6 months ago

@chan-hoo, Thank you very much for running the updated config.aqm.community.yaml sample script and config.aqm_grid_AQWM_NA13km_suite_GFS_v16.yaml WE2E test!

Please run the fundamental test suite on one of the machines as well, to ensure that these changes don't adversely affect the fundamental test suite.

In the tests/WE2E directory, using:

./run_WE2E_tests.py -t fundamental -m <machine> -a <account>

will allow you to run the fundamental test suite on a given machine. Since you are still onboarding to EPIC, please let me know and I can run the fundamental test suite on a machine for you.

Thanks

chan-hoo commented 6 months ago

@MichaelLueken, the fundamental test has been completed successfully on Hera:

All 7 experiments finished
Calculating core-hour usage and printing final summary
----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE               8.80
nco_grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_timeoffset_suite_  COMPLETE              11.89
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240  COMPLETE               6.99
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              13.70
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024022  COMPLETE              26.67
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20240220160  COMPLETE              13.61
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024022016095  COMPLETE              19.35
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             101.01
MichaelLueken commented 6 months ago

@chan-hoo, thank you very much for running the fundamental tests on Hera! Once my AQM testing is complete, I will provide an approval for this work.

chan-hoo commented 5 months ago

@RatkoVasic-NOAA, thank you very much for reviewing this PR!!! :)

MichaelLueken commented 5 months ago

The Jenkins tests have passed for Derecho, Hercules, Jet, and Orion. There were issues for both Hera Intel and Hera GNU. A rerun on Hera allowed the Hera Intel tests to pass, but the get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS test failed in Hera GNU. Attempting to rerun the one failed test now.

Once it passes, I will merge this PR.