ufs-community / ufs-srweather-app

UFS Short-Range Weather Application
Other
53 stars 114 forks source link

[develop] Feature cicd scorecard metric #1079

Closed BruceKropp-Raytheon closed 2 months ago

BruceKropp-Raytheon commented 2 months ago

DESCRIPTION OF CHANGES:

  1. Update CI/CD scripts to include skill-score metric output so that follow-on metrics collection can display it on metrics Dashboard.
  2. Update Jenkinsfile to fix post() section that calls follow-on metrics collection job so that it is only called once at the end, regardless if any platforms builds or tests fail independently.
  3. Update the Jenkinsfile to skip platform Nodes that appear to be offline, rather than put them in the launch queue. This also means we can re-add the NOAAcloud platforms to the list of possible Nodes to attempt. The will be skipped if they are not online.
  4. Update Jenkinsfile to include timeout limits on Build stage and Test stage, so they don't run forever.
  5. Update Jenkinsfile to allow seeing timestamps in the Jenkins console log.

Type of change

TESTS CONDUCTED:

Three separate runs to verify SUCCESS even without executing all E2E tests I. Fundamental Tests II. skill-score test only III. none

DEPENDENCIES:

DOCUMENTATION:

No new changes to the way the Jenkins job is launched.

ISSUE:

The previous update to Jenkinsfile added a trigger to another job that collects metrics of all the target platforms. It was initially in a final stage of the pipeline, but needs to only be in the post() section of the pipeline so that it is only triggered once at the end.

CHECKLIST

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

CONTRIBUTORS (optional):

Edward Snyder

MichaelLueken commented 2 months ago

The Jenkins tests successfully passed for Derecho, Gaea, Hera GNU, Hera Intel, and Hercules. There are currently issues with the Jenkins runner on Jet, but I was able to successfully run the coverage tests manually on Jet yesterday as part of my review. The nodes on Orion are currently down due to a cooling issue that was encountered last night.

I will now go ahead and merge this PR.