ufs-community / ufs-srweather-app

UFS Short-Range Weather Application
Other
55 stars 117 forks source link

[develop]: Updated ConfigWorkflow.rst to reflect changes to config_defaults.yaml (PI12) #1095

Closed jdkublnick closed 3 months ago

jdkublnick commented 3 months ago

DESCRIPTION OF CHANGES:

Type of change

TESTS CONDUCTED:

None required for documentation. The docs build successfully on my fork and can be viewed at: https://ufs-srweather-app-joshua-kublnick.readthedocs.io/en/text-us-283/UsersGuide/index.html

DEPENDENCIES:

N/A

DOCUMENTATION:

All documentation

ISSUE:

Issue #1094

CHECKLIST

LABELS (optional):

A Code Manager needs to add the following labels to this PR:

CONTRIBUTORS (optional):

@gspetro-NOAA

gspetro-NOAA commented 3 months ago

@jdkublnick Could you change the line that says:

``KMP_AFFINITY_BIAS_CORRECTION_O3``: "scatter"

to:

``KMP_AFFINITY_BIAS_CORRECTION_O3``: (Default: "scatter")

I can't comment directly on the code since it hasn't been altered in this PR.

gspetro-NOAA commented 3 months ago

@jdkublnick I also just realized that maybe the default value for CCPP_PHYS_DIR should be updated to '{{ [user.UFS_WTHR_MDL_DIR, "FV3", "ccpp", "physics", "physics", "SFC_Models", "Land", "Noahmp"] |path_join }}'?

jdkublnick commented 3 months ago

@jdkublnick I also just realized that maybe the default value for CCPP_PHYS_DIR should be updated to '{{ [user.UFS_WTHR_MDL_DIR, "FV3", "ccpp", "physics", "physics", "SFC_Models", "Land", "Noahmp"] |path_join }}'?

Updated