[develop] Transition the var_defns bash file to YAML.

christinaholtNOAA commented 4 weeks ago

DESCRIPTION OF CHANGES:

Use YAML for the configuration language at run time.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

I could use some help on updating documentation. Just pointers to the most important pieces. Let's also talk about whether that could be separated into a follow-on PR.

TESTS CONDUCTED:

[x] hera.intel
[ ] orion.intel
[ ] hercules.intel
[ ] cheyenne.intel
[ ] cheyenne.gnu
[ ] derecho.intel
[ ] gaea.intel
[ ] gaeac5.intel
[ ] jet.intel
[ ] wcoss2.intel
[ ] NOAA Cloud (indicate which platform)
[ ] Jenkins
[ ] fundamental test suite
[x] comprehensive tests -- all of them, but only on Hera

DEPENDENCIES:

n/a

DOCUMENTATION:

ISSUE:

CHECKLIST

[x] My code follows the style guidelines in the Contributor's Guide
[x] I have performed a self-review of my own code using the Code Reviewer's Guide
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] My changes need updates to the documentation. I have made corresponding changes to the documentation
[ ] My changes do not require updates to the documentation (explain).
[x] My changes generate no new warnings
[x] New and existing tests pass with my changes
[ ] Any dependent changes have been merged and published

christinaholtNOAA commented 3 weeks ago

I ran the fundamental tests on Hera one more time after my last push and it's still passing.

mkavulich commented 2 weeks ago

@christinaholtNOAA It looks like ush/launch_FV3LAM_wflow.sh still attempts to source the shell version of var_defns. This will need to be updated to allow running jobs with this script (including runs from crontab).

christinaholtNOAA commented 4 days ago

I've finally managed to revisit this PR, and have pushed changes. I plan to update the branch to the top of develop, and re-run the fundamental tests shortly. I'll check back in when that's been completed.

christinaholtNOAA commented 3 days ago

I merged with develop, rebuilt, and re-ran the fundamental tests on Hera. They all completed successfully with the changes I've just pushed.

I also tested the new launch_FV3LAM_wflow.sh manually to ensure it ran rocotorun and completed without errors. I did not test it from the cron.

ufs-community / ufs-srweather-app