ufs-community / ufs-srweather-app

UFS Short-Range Weather Application
Other
55 stars 116 forks source link

[develop]: Update requests and certifi in requirements.txt #1103

Closed gspetro-NOAA closed 1 month ago

gspetro-NOAA commented 2 months ago

DESCRIPTION OF CHANGES:

The Dependabot PR #1101 identified the need to update the certifi version, but requests should also be updated from the current (yanked) version in the requirements file.

Type of change

TESTS CONDUCTED:

None required. Generated the requirements file locally with the proposed upgrade to certifi and then resolved warnings generated by the requests version. With these two updates, the requirements.txt file can be generated without warnings or errors.

DEPENDENCIES:

None.

DOCUMENTATION:

All documentation.

ISSUE:

Fixes issue identified in Dependabot PR #1101

CHECKLIST

natalie-perlin commented 1 month ago

Could the ./ufs-srweather-app/doc/README be updates as well in this PR?

When sphinx, sphinx-rtd-theme have been installed (not going into the details of installations), the way to build the html documentaion requires the following:

$ cd ufs-srweather-app/doc $ cp conf.py UsersGuide/. $ make clean && sphinx-build -b html UsersGuide/ build

The above three lines would replace lines 23-24 in the current README https://github.com/ufs-community/ufs-srweather-app/blob/develop/doc/README

gspetro-NOAA commented 1 month ago

@natalie-perlin I updated the doc README (and the regular README), but I used a two-line update rather than what you suggested. There should be no need to copy the conf.py file anywhere.

MichaelLueken commented 1 month ago

Thank you for updating the README files as well, @gspetro-NOAA! Moving forward with merging this work now.