ufs-community / ufs-srweather-app

UFS Short-Range Weather Application
Other
55 stars 116 forks source link

[production/AQM.v7] Merge the changes to address NCO's review comments on AQMv7 delivery package partly #965

Closed JianpingHuang-NOAA closed 10 months ago

JianpingHuang-NOAA commented 10 months ago

This PR is used to address Issue 964 (https://github.com/ufs-community/ufs-srweather-app/issues/964) partly

TESTS CONDUCTED:

CHECKLIST

LABELS (optional):

chan-hoo commented 10 months ago

@JianpingHuang-NOAA, please do not remove anything in manage_externals. I'll move it on my end.

chan-hoo commented 10 months ago

@JianpingHuang-NOAA, why do you delete the input files for FV3_GFS_v16 such as diag_table and field_table in the parm directory? How does your NRT run without those files?

JianpingHuang-NOAA commented 10 months ago

Yes, I only keep those related aqm. I did not find any impact on our model running and results. I have completed the tests

chan-hoo commented 10 months ago

@JianpingHuang-NOAA, which CCPP physics suite are you using in your NRT?

JianpingHuang-NOAA commented 10 months ago

@JianpingHuang-NOAA, please do not remove anything in manage_externals. I'll move it on my end.

I deleted "test" subdirectory only under ~/manage_external. I am not comfortable with other changes. So I leave them for you.

chan-hoo commented 10 months ago

@JianpingHuang-NOAA, I can see the files in your branch, but the PR is saying they are deleted. Strange ....

chan-hoo commented 10 months ago

@JianpingHuang-NOAA, I got it now. They have different names for AQM. Sorry. I was confused. Approving now.