ufs-community / ufs-srweather-app

UFS Short-Range Weather Application
Other
55 stars 116 forks source link

Incorrect octal notation causing ensemble vx to fail #966

Closed michelleharrold closed 8 months ago

michelleharrold commented 10 months ago

Expected behavior

When running verification on ensembles with membership >=8, verification should successfully complete.

Current behavior

The current way for calculating ensmem_indx=$(printf "%0${VX_NDIGITS_ENSMEM_NAMES}d" "${ENSMEM_INDX}") is causing octal issues for members 8 and 9.

Machines affected

Any machine running ensemble verification will be affected.

Steps To Reproduce

Run WE2E test: ufs-srweather-app/tests/WE2E/test_configs/verification/config.MET_ensemble_verification.yaml But change NUM_ENS_MEMBERS from 2 to 10.

Detailed Description of Fix (optional)

Perhaps there are better ways to address this, but this is one option of addressing the issue: ensmem_indx=$(printf "%0${VX_NDIGITS_ENSMEM_NAMES}d" $(( 10#${ENSMEM_INDX})))

This will need to be updated in exregional_check_post_output.sh, exregional_run_met_pcpcombine.sh, and exregional_run_met_gridstat_or_pointstat_vx.sh.

Thanks to @mkavulich for helping with this!