search

ufs-community / ufs-srweather-app

UFS Short-Range Weather Application
Other
55 stars 116 forks source link

[production/AQM.v7] Using standard environmental variable names #971

Closed JianpingHuang-NOAA closed 9 months ago

JianpingHuang-NOAA commented 10 months ago

According to implementation EE2 requirements for AQMv7, we have to use aqm-dependent variable names such as USHaqm and EXECaqm rather than USHdir and EXECdir. The issue has been found in all the JAQM and exaqm scripts.

chan-hoo commented 10 months ago

@JianpingHuang-NOAA, Who commented this? As far as I know, Steven confirmed that we could use *dir except for HOMEaqm. @MatthewPyle-NOAA, is this correct?

MatthewPyle-NOAA commented 10 months ago

@chan-hoo it was at least at one point about a year ago. From September 2022 - seemed like he preferred things like PARM rather than PARMdir. But given their prickliness with the first handoff, it would be safest to make things be like PARMaqm (for example). 

For the initial implementation, would this work:
HOMErrfs
USH
FIX
EXEC

Then we explore changing this standard with the next transition to something like:
HOMErrfs
USHDIR
FIXDIR
BINDIR
JianpingHuang-NOAA commented 10 months ago

@chan-hoo I got this comment from Carlos (NCO) who is working on the implementation of AQMv7