[production/AQM.v7] Hard-coded paths in any scripts or version numbers outside of run.ver/build.ver

ufs-community / ufs-srweather-app

UFS Short-Range Weather Application

Other

56 stars 119 forks source link

[production/AQM.v7] Hard-coded paths in any scripts or version numbers outside of run.ver/build.ver #972

Closed JianpingHuang-NOAA closed 11 months ago

JianpingHuang-NOAA commented 11 months ago

According to NOC, make sure there's no hard-coded paths in any scripts or version numbers outside of run.ver/build.ver.

e.g. ush/etc/lmod-setup.sh:54: export BASH_ENV="/usr/local/lmod/8.3.1/init/bash"

chan-hoo commented 11 months ago

@JianpingHuang-NOAA, The etc/lmod_setup.sh is only used while compiling for ecFlow since the modules are loaded directly from the ecflow script. I'll remove the line for calling this script. Therefore, we can remove the ush/etc directory.

chan-hoo commented 11 months ago

@JianpingHuang-NOAA, I've remove it.

JianpingHuang-NOAA commented 11 months ago

@chan-hoo Please have a double check and make sure that no hard-coded paths in any scripts or version numbers outside of run.ver/build.ver. Thanks !