search

ufs-community / ufs-weather-model

UFS Weather Model
Other
134 stars 239 forks source link

Update CDEPS ESMF Config format #1548

Open uturuncoglu opened 1 year ago

uturuncoglu commented 1 year ago

Description

The stream definition config file is diverged between XML and ESMF Config options. This needs to be fixed.

Solution

The shr_stream_init_from_esmfconfig() call under CDEPS/streams/dshr_stream_mod.F90 needs to be updated to reflect recent changes in CDEPS side to make both XML and ESMF Config formats are consistent.

Alternatives

N/A

Related to

This is also explained in the https://github.com/ESCOMP/CDEPS/issues/200

uturuncoglu commented 1 year ago

@junwang-noaa @binli2337 I am currently working on CDEPS documentation as a part of JTTI land project and I realized that the keys used in XML and ESMF Config formats to define data stream configurations are diverged. The potential changes in shr_stream_init_from_esmfconfig() will probably affect the parameter files under tests/parm directory. I just wonder that you are fine with those changes. I think we might also support old keys, which might not lead any change in the RT configuration files. Anyway, let me know what you think?

junwang-noaa commented 1 year ago

@uturuncoglu I think it is good to have consistent XML and ESMF config formats. Really appreciate it if you can sync UFS CDEPS branch with the latest code updates and make changes in the files under UFS WM tests/parm. Thanks

uturuncoglu commented 1 year ago

@junwang-noaa Sure. I could include them to my next PR related with land coupling.

DeniseWorthen commented 6 months ago

This issue is almost a year old. Is it fixed?

uturuncoglu commented 6 months ago

@DeniseWorthen No. I could not find time to fix it. I think this also involves some work with the CDEPS specific RT template files.

DeniseWorthen commented 6 months ago

@uturuncoglu OK, thanks for the update.