ufs-community / ufs-weather-model

UFS Weather Model
Other
129 stars 238 forks source link

Adding a few JEDI-related aliases into the `fd_ufs.yaml` file+Add option to specify fv3atm history and inline post files output directory #2254 + Bump jinja2 from 3.1.3 to 3.1.4 in /doc/UsersGuide #2270 #2215

Closed fabiolrdiniz closed 1 week ago

fabiolrdiniz commented 1 month ago

Commit Queue Requirements:

For the JEDI-UFS integration, several aliases are needed in fd_ufs.yaml. This PR adds the missing aliases.

Add new model_configure option (fv3atm_output_dir) to specify directory in which all history and inline post files will be saved.

Commit Message:

* UFSWM - Add several aliases in `fd_ufs.yaml` needed for JEDI-UFS. Add new model_configure option (fv3atm_output_dir) to specify directory in which all fv3atm history and inline post files will be saved.
  * FV3 -  Add new model_configure option (fv3atm_output_dir) to specify directory in which all history and inline post files will be saved.

Priority:

Git Tracking

UFSWM

ISSUES

Sub component Pull Requests:

UFSWM Blocking Dependencies:

Input data Changes:

Library Changes/Upgrades:


Testing Log:

climbfuji commented 2 weeks ago

@jkbk2004 JCSDA needs this PR - I can pick it up where it is and get it ready. Can we add this to the commit queue for tomorrow's meeting?

climbfuji commented 1 week ago

@jkbk2004 I ran rt.sh for this PR on Derecho for the latest commit (https://github.com/ufs-community/ufs-weather-model/pull/2215/commits/9299932bbda8eaa0acfd2f4e7d7be0f9101a5b9e) - which is up to date with develop - and all regression tests passed against the existing baseline. test_changes.list submitted as requested. PR is ready!

jkbk2004 commented 1 week ago

@fabiolrdiniz can you sync up the branch one more time? We can start working on this pr. Note that we are considering to combine in #2253 and #2254.

jkbk2004 commented 1 week ago

@DusanJovic-NOAA I combined in #2254 to this pr.

zach1221 commented 1 week ago

I'll do a prelim test of the combined PR on hercules.

Tests all passed. RegressionTests_hercules.log

zach1221 commented 1 week ago

@FernandoAndrade-NOAA @BrianCurtis-NOAA I think we can begin testing here.

zach1221 commented 1 week ago

Regression testing is complete. We can proceed with merging process.

BrianCurtis-NOAA commented 1 week ago

The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.

zach1221 commented 1 week ago

The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.

Commit message is updated.

DusanJovic-NOAA commented 1 week ago

The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.

Commit message is updated.

Please do not use ampersand sign in commit message

BrianCurtis-NOAA commented 1 week ago

The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.

Commit message is updated.

I've made edits, it should look more like this. we don't need all the extra information. I had to bring in issues we're closing with this PR from other PR's