Closed fabiolrdiniz closed 1 week ago
@jkbk2004 JCSDA needs this PR - I can pick it up where it is and get it ready. Can we add this to the commit queue for tomorrow's meeting?
@jkbk2004 I ran rt.sh for this PR on Derecho for the latest commit (https://github.com/ufs-community/ufs-weather-model/pull/2215/commits/9299932bbda8eaa0acfd2f4e7d7be0f9101a5b9e) - which is up to date with develop - and all regression tests passed against the existing baseline. test_changes.list
submitted as requested. PR is ready!
@fabiolrdiniz can you sync up the branch one more time? We can start working on this pr. Note that we are considering to combine in #2253 and #2254.
@DusanJovic-NOAA I combined in #2254 to this pr.
I'll do a prelim test of the combined PR on hercules.
Tests all passed. RegressionTests_hercules.log
@FernandoAndrade-NOAA @BrianCurtis-NOAA I think we can begin testing here.
Regression testing is complete. We can proceed with merging process.
The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.
The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.
Commit message is updated.
The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.
Commit message is updated.
Please do not use ampersand sign in commit message
The template is incomplete. We're probably not using that commit message. When we merge many PR's into one it's important to make sure the template is also updated.
Commit message is updated.
I've made edits, it should look more like this. we don't need all the extra information. I had to bring in issues we're closing with this PR from other PR's
Commit Queue Requirements:
[x] Commit 'test_changes.list' from previous step
Description:
For the JEDI-UFS integration, several aliases are needed in
fd_ufs.yaml
. This PR adds the missing aliases.Add new model_configure option (fv3atm_output_dir) to specify directory in which all history and inline post files will be saved.
Commit Message:
Priority:
Git Tracking
UFSWM
ISSUES
MERGED PR'S
Sub component Pull Requests:
UFSWM Blocking Dependencies:
None
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log: