ufs-community / ufs-weather-model

UFS Weather Model
Other
129 stars 238 forks source link

add a model_configure template for global nest #2252

Open guoqing-noaa opened 3 weeks ago

guoqing-noaa commented 3 weeks ago

Commit Queue Requirements:

Commit Message:

add a model_configure template for global nest tests/parm/model_configure_nest.IN

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:


Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Library Changes/Upgrades:


Testing Log:

DeniseWorthen commented 1 week ago

@jkbk2004 This PR is requesting high priority.

DusanJovic-NOAA commented 1 week ago

Which regression test is using (testing) this template?

guoqing-noaa commented 1 week ago

Which regression test is using (testing) this template?

This is a new template for the global nest applications. No existing regression tests for it. @SamuelTrahanNOAA is trying to add a global nest regression test to this repo. Could you convert this PR to a draft PR at this moment? Thanks!

SamuelTrahanNOAA commented 1 week ago

There are regression tests in the repository already. I'm replacing one of them.

These are the tests:

  1. gnv1_c96_no_nest_debug - unnested uncoupled C96 GFS with global_nest_v1 physics suite. Code is compiled in debug mode. Run for GNU and Intel compilers. It uses the exact same C96 input as dozens of other ufs-weather-model regression tests.
  2. gnv1_nested - HAFS North Atlantic global nested test case with global_nest_v1 physics. This is the same input used for other HAFS global cases. Compiled optimized; intel only.

I'm replacing the second one (gnv1_nested). It'll use the Water in the West domain instead of the HAFS North Atlantic domain. Also, it'll be based on the GFS-like regression tests (using control_run.IN) so it'll be more compatible with the global-workflow.

SamuelTrahanNOAA commented 1 week ago

I'm unclear on what is gained by merging this PR. The reason it is high priority is that a global-workflow PR needs a model_configure for the global_nest_v1 suite. However, the global-workflow PR generates an incorrect input.nml. Its namelist settings don't match the ccpp suite. The new file isn't used by any regression test yet.

Also, the NEST_ variables won't work long-term. What if there is more than one nest?

I'll have another PR soon with a regression test that has a correct namelist.

guoqing-noaa commented 1 week ago

I'm unclear on what is gained by merging this PR. The reason it is high priority is that a global-workflow PR needs a model_configure for the global_nest_v1 suite. However, the global-workflow PR generates an incorrect input.nml. Its namelist settings don't match the ccpp suite. The new file isn't used by any regression test yet.

Also, the NEST_ variables won't work long-term. What if there is more than one nest?

I'll have another PR soon with a regression test that has a correct namelist.

@SamuelTrahanNOAA If you will create another PR, I will close this PR. Thanks!

SamuelTrahanNOAA commented 1 day ago

My replacement PR is #2284. Unfortunately, the model isn't stable for the C96 case, and I have no fix for that yet. Please see that PR for details.