ufs-community / ufs-weather-model

UFS Weather Model
Other
129 stars 238 forks source link

Bug fix for ccpp-physics routine sfcsub.F #2253

Closed GeorgeGayno-NOAA closed 1 week ago

GeorgeGayno-NOAA commented 2 weeks ago

Commit Queue Requirements:

A bug fix was made to ccpp-physics routine sfcsub.F. This PR updates the version of ccpp-physics used by ufs-weather-model.

Commit Message:

Priority:

Git Tracking

Sub component Pull Requests:

UFSWM Blocking Dependencies:

Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Library Changes/Upgrades:


Testing Log:

GeorgeGayno-NOAA commented 2 weeks ago

All regression tests passed on Hera: https://github.com/GeorgeGayno-NOAA/ufs-weather-model/blob/sfcsub_fix/tests/logs/RegressionTests_hera.log

jkbk2004 commented 1 week ago

@GeorgeGayno-NOAA Can you sync up the branches? We will try to see if we can combine along with #2215 and #2254.

grantfirl commented 1 week ago

@GeorgeGayno-NOAA Can you sync up the branches? We will try to see if we can combine along with #2215 and #2254.

@jkbk2004 I've already combined this into #2264. I'll get it updated, although there was a little discussion left on one of the combined ccpp-physics PRs that is finishing up.

jkbk2004 commented 1 week ago

@GeorgeGayno-NOAA Can you sync up the branches? We will try to see if we can combine along with #2215 and #2254.

@jkbk2004 I've already combined this into #2264. I'll get it updated, although there was a little discussion left on one of the combined ccpp-physics PRs that is finishing up.

@grantfirl thanks for the note! it helps. We will separately go with #2215 and #2254.

grantfirl commented 1 week ago

@jkbk2004 This can be closed in favor of https://github.com/ufs-community/ufs-weather-model/pull/2264