search

ufs-community / ufs-weather-model

UFS Weather Model
Other
129 stars 238 forks source link

Modify module files to compile on AWS with spack-stack-1.6.0 #2258

Open weihuang-jedi opened 2 weeks ago

weihuang-jedi commented 2 weeks ago

Modify module files to compile on AWS with spack-stack-1.6.0

Solve issue: #2257 2257 (https://github.com/ufs-community/ufs-weather-model/issues/2257)

This code change is in the effort to implement global-workflow on AWS and other NOAA Cloud machines, and use spack-stack 1.6.0.

Testing Log:

jkbk2004 commented 2 weeks ago

@weihuang-jedi this pr can be combined to #2093

weihuang-jedi commented 2 weeks ago

Old lines with comments removed.

On Tue, Apr 30, 2024 at 8:55 AM RatkoVasic-NOAA @.***> wrote:

@.**** commented on this pull request.

In CMakeLists.txt https://github.com/ufs-community/ufs-weather-model/pull/2258#discussion_r1584974661 :

+#find_package(NetCDF 4.7.4 REQUIRED C Fortran) +#find_package(ESMF 8.3.0 MODULE REQUIRED)

Please remove old lines with comments.

— Reply to this email directly, view it on GitHub https://github.com/ufs-community/ufs-weather-model/pull/2258#pullrequestreview-2031632779, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMCH67EYGLXRYL77PBSJ7TY76WEBAVCNFSM6AAAAABG65OSRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZRGYZTENZXHE . You are receiving this because you were mentioned.Message ID: @.***>

weihuang-jedi commented 2 weeks ago

Right now, current UFS-model use spack-stack 1.5.1, AWS uses 1.6.0, which use different NetCDF and ESMF libs. Remove versions will relax those version requirements, but just the library (if any version exist). So, unless UFS-model depends on specific version of those libs, version is not necessary. Also we load those libs through module files, where we define the version numbers.

Or, as there is a PR 2093, is update spack-stack libs to 1.6.0, we can wait after that PR is merged, and put back the versions.

On Tue, Apr 30, 2024 at 9:03 AM Dusan Jovic @.***> wrote:

@.**** commented on this pull request.

In CMakeLists.txt https://github.com/ufs-community/ufs-weather-model/pull/2258#discussion_r1584989557 :

+#find_package(NetCDF 4.7.4 REQUIRED C Fortran) +#find_package(ESMF 8.3.0 MODULE REQUIRED)

Why are version numbers removed?

— Reply to this email directly, view it on GitHub https://github.com/ufs-community/ufs-weather-model/pull/2258#discussion_r1584989557, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMCH6ZYF3BQRID44XA6HI3Y76XD3AVCNFSM6AAAAABG65OSRWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMZRGY3DKNRTG4 . You are receiving this because you were mentioned.Message ID: @.***>

RatkoVasic-NOAA commented 2 weeks ago

@weihuang-jedi as @jkbk2004 said, how about you create PR to #2093? In that case you can replace old ufs_common.lua with your new one (so we have one less file). We will run tests again to see how ufs works on other machines with new ESMF, FMS, NETCDF, SP and MAPL. And we can keep app version numbers in CMakeLists.txt file. That would be PR to this branch: https://github.com/RatkoVasic-NOAA/ufs-weather-model/tree/ss-160

weihuang-jedi commented 2 weeks ago

Actually, I think combine together is not straight forward, as my code is branched from fork: https://github.com/NOAA-EPIC/ufs-weather-model-cloud/tree/wei-epic-aws Easy way is still #2093 merge first, then I can sync my code, and ask for merge again. Other wise, we probably need to manually copy over code, or I do not how to merge two forked code together. After #2093 merged in, I'll try to not modify CMakeLists.txt, and remove ufs_common4noaaloud.lua but keep other changes.

Will this be OK?

On Tue, Apr 30, 2024 at 9:41 AM RatkoVasic-NOAA @.***> wrote:

@weihuang-jedi https://github.com/weihuang-jedi as @jkbk2004 https://github.com/jkbk2004 said, how about you create PR to #2093 https://github.com/ufs-community/ufs-weather-model/pull/2093? In that case you can replace old ufs_common.lua with your new one (so we have one less file). We will run tests again to see how ufs works on other machines with new ESMF, FMS, NETCDF, SP and MAPL. And we can keep app version numbers in CMakeLists.txt file. That would be PR to this branch: https://github.com/RatkoVasic-NOAA/ufs-weather-model/tree/ss-160

— Reply to this email directly, view it on GitHub https://github.com/ufs-community/ufs-weather-model/pull/2258#issuecomment-2085714425, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMCH67DPZWK22THI5AKTQDY763RVAVCNFSM6AAAAABG65OSRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVG4YTINBSGU . You are receiving this because you were mentioned.Message ID: @.***>

RatkoVasic-NOAA commented 2 weeks ago

@weihuang-jedi, that works with me as well. @jkbk2004 are there any news on WCOSS2 installing spack-stack-1.6.0? My branch ss-170 is ready for PR for spack-stack-1.7.0 already.