search

ufs-community / ufs-weather-model

UFS Weather Model
Other
129 stars 238 forks source link

Update CICE to CICE-Consortium (2024-05-01)+update mom6 to its main repo. 20240508 commit #2275 #2259

Closed NickSzapiro-NOAA closed 3 days ago

NickSzapiro-NOAA commented 2 weeks ago

Commit Queue Requirements:

Commit Message:

* UFSWM - Update CICE to CICE-Consortium (2024-05-01) and mom6 to its main repo (2024-05-08)
  * CICE - Update CICE to CICE-Consortium (2024-05-01)
  * MOM6 - Update mom6 to its main repo. 20240508 commit

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Library Changes/Upgrades:

Testing Log:

jkbk2004 commented 1 week ago

@pjpegion @jiandewang I merged in #2271 and #2275 to this pr. Can you check?

jiandewang commented 1 week ago

MOM is pointing to the right branch. Thanks

BrianCurtis-NOAA commented 6 days ago

As per instructions in the previous pull request (see: https://github.com/ufs-community/ufs-weather-model/pull/2215#issuecomment-2102701561), @jkbk2004 and team: when you combine multiple pull requests together its extremely important to bring all of the information from the outside PR's into the combined PR.

jkbk2004 commented 6 days ago

It's strange to see compile error on gaea with physics. It ran ok on hera/orion/hercules though.

/gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(236): error #8\
284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type charact\
er or is an element of an array that is not assumed shape, pointer, or polymorphic.   [SIG1T]
      CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, &
-----------^
compilation aborted for /gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/g\
cycle.F90 (code 1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/build.make:296: FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir\
/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90.o] Error 1
jkbk2004 commented 6 days ago

As per instructions in the previous pull request (see: #2215 (comment)), @jkbk2004 and team: when you combine multiple pull requests together its extremely important to bring all of the information from the outside PR's into the combined PR.

@BrianCurtis-NOAA @zach1221 @FernandoAndrade-NOAA Thanks for the note! We will make sure to pull out all the PR information when PR is ready.

BrianCurtis-NOAA commented 6 days ago

As per instructions in the previous pull request (see: #2215 (comment)), @jkbk2004 and team: when you combine multiple pull requests together its extremely important to bring all of the information from the outside PR's into the combined PR.

@BrianCurtis-NOAA @zach1221 @FernandoAndrade-NOAA Thanks for the note! We will make sure to pull out all the PR information when PR is ready.

This should be completed before the PR starts testing. Testing is the final stage of the PR process before merge.

jkbk2004 commented 6 days ago

It's strange to see compile error on gaea with physics. It ran ok on hera/orion/hercules though.

/gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(236): error #8\
284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type charact\
er or is an element of an array that is not assumed shape, pointer, or polymorphic.   [SIG1T]
      CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, &
-----------^
compilation aborted for /gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/g\
cycle.F90 (code 1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/build.make:296: FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir\
/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90.o] Error 1

@pjpegion The gaea build failures came from #2271. I am detaching #2271.

BrianCurtis-NOAA commented 6 days ago

It's strange to see compile error on gaea with physics. It ran ok on hera/orion/hercules though.

/gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(236): error #8\
284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type charact\
er or is an element of an array that is not assumed shape, pointer, or polymorphic.   [SIG1T]
      CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, &
-----------^
compilation aborted for /gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/g\
cycle.F90 (code 1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/build.make:296: FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir\
/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90.o] Error 1

@pjpegion The gaea build failures came from #2271. I am detaching #2271.

@jkbk2004 can you please elaborate on how this comes from #2271? You said it ran fine on three other platforms. This leans to being a gaea issue, not a PR issue.

jkbk2004 commented 6 days ago

It's strange to see compile error on gaea with physics. It ran ok on hera/orion/hercules though.

/gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(236): error #8\
284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type charact\
er or is an element of an array that is not assumed shape, pointer, or polymorphic.   [SIG1T]
      CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, &
-----------^
compilation aborted for /gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/g\
cycle.F90 (code 1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/build.make:296: FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir\
/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90.o] Error 1

@pjpegion The gaea build failures came from #2271. I am detaching #2271.

@jkbk2004 can you please elaborate on how this comes from #2271? You said it ran fine on three other platforms. This leans to being a gaea issue, not a PR issue.

If I detach PR 2271, it runs ok even on gaea. Strange PR 2271 has nothing to do with physics but it looks like there is a confliction.

jkbk2004 commented 6 days ago

Anyway, I feel comfortable to say this PR combining with #2275 is ready. @zach1221 @FernandoAndrade-NOAA can you pick up from here and complete the PR templates ?

BrianCurtis-NOAA commented 6 days ago

It's strange to see compile error on gaea with physics. It ran ok on hera/orion/hercules though.

/gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(236): error #8\
284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type charact\
er or is an element of an array that is not assumed shape, pointer, or polymorphic.   [SIG1T]
      CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, &
-----------^
compilation aborted for /gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/g\
cycle.F90 (code 1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/build.make:296: FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir\
/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90.o] Error 1

@pjpegion The gaea build failures came from #2271. I am detaching #2271.

@jkbk2004 can you please elaborate on how this comes from #2271? You said it ran fine on three other platforms. This leans to being a gaea issue, not a PR issue.

If I detach PR 2271, it runs ok even on gaea. Strange PR 2271 has nothing to do with physics but it looks like there is a confliction.

You're not really answering the question here: Did you do any work towards finding out WHY it failed on Gaea when it didn't fail on any other platform?

What has happened here is a waste of resources on Hera, Orion, Hercules, WCOSS2, Acorn. Since you've just detached a PR without a reason why, we all have to run this whole PR again.

jkbk2004 commented 6 days ago

It's strange to see compile error on gaea with physics. It ran ok on hera/orion/hercules though.

/gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(236): error #8\
284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type charact\
er or is an element of an array that is not assumed shape, pointer, or polymorphic.   [SIG1T]
      CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, &
-----------^
compilation aborted for /gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/g\
cycle.F90 (code 1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/build.make:296: FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir\
/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90.o] Error 1

@pjpegion The gaea build failures came from #2271. I am detaching #2271.

@jkbk2004 can you please elaborate on how this comes from #2271? You said it ran fine on three other platforms. This leans to being a gaea issue, not a PR issue.

If I detach PR 2271, it runs ok even on gaea. Strange PR 2271 has nothing to do with physics but it looks like there is a confliction.

You're not really answering the question here: Did you do any work towards finding out WHY it failed on Gaea when it didn't fail on any other platform?

What has happened here is a waste of resources on Hera, Orion, Hercules, WCOSS2, Acorn. Since you've just detached a PR without a reason why, we all have to run this whole PR again.

I completely agree current RT test cases (240 case and 8 or 9 platforms) are too intensive for pre-tests or daily runs.

BrianCurtis-NOAA commented 6 days ago

It's strange to see compile error on gaea with physics. It ran ok on hera/orion/hercules though.

/gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(236): error #8\
284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type charact\
er or is an element of an array that is not assumed shape, pointer, or polymorphic.   [SIG1T]
      CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, &
-----------^
compilation aborted for /gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/g\
cycle.F90 (code 1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/build.make:296: FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir\
/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90.o] Error 1

@pjpegion The gaea build failures came from #2271. I am detaching #2271.

@jkbk2004 can you please elaborate on how this comes from #2271? You said it ran fine on three other platforms. This leans to being a gaea issue, not a PR issue.

If I detach PR 2271, it runs ok even on gaea. Strange PR 2271 has nothing to do with physics but it looks like there is a confliction.

You're not really answering the question here: Did you do any work towards finding out WHY it failed on Gaea when it didn't fail on any other platform? What has happened here is a waste of resources on Hera, Orion, Hercules, WCOSS2, Acorn. Since you've just detached a PR without a reason why, we all have to run this whole PR again.

I completely agree current RT test cases (240 case and 8 or 9 platforms) are too intensive for pre-tests or daily runs.

Please, can you describe the debugging you did with the failure on Gaea?

jkbk2004 commented 6 days ago

It's strange to see compile error on gaea with physics. It ran ok on hera/orion/hercules though.

/gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90(236): error #8\
284: If the actual argument is scalar, the dummy argument shall be scalar unless the actual argument is of type charact\
er or is an element of an array that is not assumed shape, pointer, or polymorphic.   [SIG1T]
      CALL SFCCYCLE (9998, npts, max(lsoil,lsoil_lsm), sig1t, fhcyc, &
-----------^
compilation aborted for /gpfs/f5/epic/scratch/Jong.Kim/rt-2259/FV3/ccpp/physics/physics/Interstitials/UFS_SCM_NEPTUNE/g\
cycle.F90 (code 1)
make[2]: *** [FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir/build.make:296: FV3/ccpp/physics/CMakeFiles/ccpp_physics.dir\
/physics/Interstitials/UFS_SCM_NEPTUNE/gcycle.F90.o] Error 1

@pjpegion The gaea build failures came from #2271. I am detaching #2271.

@jkbk2004 can you please elaborate on how this comes from #2271? You said it ran fine on three other platforms. This leans to being a gaea issue, not a PR issue.

If I detach PR 2271, it runs ok even on gaea. Strange PR 2271 has nothing to do with physics but it looks like there is a confliction.

You're not really answering the question here: Did you do any work towards finding out WHY it failed on Gaea when it didn't fail on any other platform? What has happened here is a waste of resources on Hera, Orion, Hercules, WCOSS2, Acorn. Since you've just detached a PR without a reason why, we all have to run this whole PR again.

I completely agree current RT test cases (240 case and 8 or 9 platforms) are too intensive for pre-tests or daily runs.

Please, can you describe the debugging you did with the failure on Gaea? see the attached test result working fine if I detach PR2271. We need to move this debugging discussion to #2271. RegressionTests_gaea.log

DusanJovic-NOAA commented 6 days ago

@jkbk2004 Which test failed to compile on gaea?

jkbk2004 commented 6 days ago

@jkbk2004 Which test failed to compile on gaea?

@DusanJovic-NOAA They are rap_control_debug_dyn32_phy32 intel, hrrr_control_debug_dyn32_phy32 intel, conus13km_debug intel, conus13km_debug_qr intel, conus13km_debug_2threads intel, conus13km_radar_tten_debug intel. I will move to #2271 to follow on.

jiandewang commented 3 days ago

@zach1221 I am heading for a dental appt. now, so if it comes to the point that needs MOM6 merging, please bear me a bit delay.

jiandewang commented 3 days ago

@zach1221 my dental appt. finished earlier than expected. Back to business now. Let me know when its time I shall do MOM6 merging

BrianCurtis-NOAA commented 3 days ago

At this point if we're waiting on Acorn only, then skip it. Lots of testing SA work going on Acorn, and it's currently not running there.

FernandoAndrade-NOAA commented 3 days ago

Ok, I'll leave a note in the sub PRs to continue with the merge process.

jiandewang commented 3 days ago

just merged MOM6 woth hash 3bcfbbea

NickSzapiro-NOAA commented 3 days ago

@DeniseWorthen @jiandewang Updated CICE and MOM6 hashes