ufs-community / ufs-weather-model

UFS Weather Model
Other
142 stars 249 forks source link

Submodule pointer update (fv3atm, ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) #2464

Closed climbfuji closed 1 month ago

climbfuji commented 1 month ago

Commit Queue Requirements:

This PR updates the submodule pointer for fv3atm and ccpp-framework for the changes described in https://github.com/NCAR/ccpp-framework/pull/600 (Bug fix for unit conversion error in ccpp_prebuild.py (variables that are slices of a n+1 dimensional array have wrong allocation). There are no code changes in fv3atm or ufs-weather-model. The bug that is being fixed did not affect the UFS Weather Model, hence there are no answer changes associated with this update. However, because the variable declaration for interface variables in the auto-generated CCPP caps changed slightly, I ran the full regression tests on Hera - all b4b.

Commit Message:

* UFSWM - Submodule pointer update (fv3atm, ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py)
  * AQM - 
  * CDEPS - 
  * CICE - 
  * CMEPS - 
  * CMakeModules - 
  * FV3 - Submodule pointer update for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py)
    * ccpp-framework - Please use PR description as commit message
    * ccpp-physics - 
    * atmos_cubed_sphere - 
  * GOCART - 
  * HYCOM - 
  * MOM6 - 
  * NOAHMP - 
  * WW3 - 
  * fire_behavior
  * stochastic_physics - 

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:


Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Library Changes/Upgrades:


Testing Log:

climbfuji commented 1 month ago

@DusanJovic-NOAA This won't be needed because you are pointing to my ccpp-framework branch, correct?

jkbk2004 commented 1 month ago

merged with #2463