ufs-community / ufs-weather-model

UFS Weather Model
Other
142 stars 248 forks source link

Fix/cpld sfs rt + Pull in units updates from FV3 #2467 #2475

Closed dpsarmie closed 2 weeks ago

dpsarmie commented 1 month ago

Commit Queue Requirements:

Commit Message:

* UFSWM - Updates cpld_control_sfs to use the most up-to-date configuration specs
* UFSWM - Update units attributes in netCDF output to be machine-readable
  * FV3 - Update units attributes in netCDF output to be machine-readable
    * atmos_cubed_sphere - Update units attributes in netCDF output to be machine-readable

Priority:

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:


Changes

Regression Test Changes (Please commit test_changes.list):

Input data Changes:

Library Changes/Upgrades:


Testing Log:

jkbk2004 commented 3 weeks ago

@dpsarmie can you sync up branch? Also, we want to combine in #2467. just need to point to https://github.com/DWesl/fv3atm/tree/sty-unit-consistency.

jkbk2004 commented 2 weeks ago

W can start merging process.

jkbk2004 commented 2 weeks ago

@dpsarmie new fv3 hash is https://github.com/NOAA-EMC/fv3atm/commit/bd785e50f90985fb1330e36852297af38293415b

jkbk2004 commented 2 weeks ago

@BrianCurtis-NOAA We need to re-create baselines. it looks like the feature branch pointer was messed up. I only see cosmetic unit issue like

23c23
<               pfull:units = "mb" ;
---
>               pfull:units = "mbar" ;
28c28
<               phalf:units = "mb" ;
---
>               phalf:units = "mbar" ;
423c423
<               lhtfl_ave:units = "w/m**2" ;
---
>               lhtfl_ave:units = "W/m**2" ;
BrianCurtis-NOAA commented 2 weeks ago

I won't be able to complete WCOSS2 for at least this week. Maintenance.

jkbk2004 commented 2 weeks ago

Baselines were restored across RDHPCS w/o problems.