ufz / ogs5

OpenGeoSys THM/C simulator version 5
https://www.opengeosys.org/ogs-5
Other
39 stars 97 forks source link

Clean CFiniteElementVec::GlobalAssembly_RHS() #102

Closed wenqing closed 6 years ago

wenqing commented 6 years ago
  1. Moved the Bishop coefficient calculation to CSolidProperties to remove the source code duplication.
  2. Removed source code duplication in checking element for excavation modelling.
  3. Removed unused source code.
  4. Reduced the if-conditions inside the loop to compute the nodal pore pressures for the coupling term.
wenqing commented 6 years ago

@norihiro-w Do you have any any comment? If not, I am going to merge it.

norihiro-w commented 6 years ago

looks okay

bilke commented 6 years ago

@wenqing I restarted the Jenkins job and now it ran successfully.

wenqing commented 6 years ago

@bilke Thanks.