search

ufz / ogs5

OpenGeoSys THM/C simulator version 5
https://www.opengeosys.org/ogs-5
Other
39 stars 97 forks source link

Wrong "if" closure of $ELEMENT_VOLUME_MULTIPLYER #110

Closed lurpi closed 6 years ago

lurpi commented 6 years ago

Hi all, The if block for reading $ELEMENT_VOLUME_MULTIPLYER starting at line https://github.com/ufz/ogs5/blob/master/FEM/rf_mmp_new.cpp#L1885 seems wrongly closed. Now it is like this: 

                << "- times the grid value \n";
  }

Should it be like this? 

                << "- times the grid value \n";
      in.clear();
      continue;
  }

Thanks for looking into the issue. Have a nice day

wenqing commented 6 years ago

Yes it should like this

|<< "- times the grid value \n"; in.clear(); continue; |
It has to be corrected. Fortunately, the reading is at the end of the loop.

On 08/23/2018 12:00 AM, lurpi wrote:

Hi all, The if block for reading $ELEMENT_VOLUME_MULTIPLYER starting at line https://github.com/ufz/ogs5/blob/master/FEM/rf_mmp_new.cpp#L1885 seems wrongly closed. Now it is like this:

|<< "- times the grid value \n"; } |

Should it be like this?

|<< "- times the grid value \n"; in.clear(); continue; } |

Thanks for looking into the issue. Have a nice day

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ufz/ogs5/issues/110, or mute the thread https://github.com/notifications/unsubscribe-auth/ABSBX6sYmqixuNf0sSsOv754IjUSGeF6ks5uTdRggaJpZM4WIfPW.

norihiro-w commented 6 years ago

@lurpi thanks for the report. The code is fixed now,