search

ufz / ogs5

OpenGeoSys THM/C simulator version 5
https://www.opengeosys.org/ogs-5
Other
39 stars 97 forks source link

Changed the term of LiquidFlow for time unit scaling factor #113

Closed wenqing closed 5 years ago

wenqing commented 5 years ago

For LiquidFlow, this PR moves the time unit scaling factor from the mass term to the Jacobian term. With this change, the time unit in the source term of LiquidFlow has to be consistency with the time unit defined in tim file. Accordingly, the NeumannBC value of one benchmark was changed (ufz/ogs5-benchmarks#19).

This PR also fixes the fluid property output and a compilation warning.

nbeyond commented 5 years ago

This sounds interesting and the corresponding benchmark looks interesting too. Would this fix make Neumann boundary conditions to work if defined CONSTANT_NEUMANN in .st files not in .bc with consistent $TIME_UNIT?

wenqing commented 5 years ago

@nbeyond This is only for LiquidFlow, which is only process that the time unit factor is applied to the mass term. The changes only influence the Neumann condition of source term of LiquidFlow. Without this change, the time unit in Neumann condition of source term of LiquidFlow is always "s" for whichever time unit is defined in tim file.

norihiro-w commented 5 years ago

it looks good for me