search

ufz / ogs5

OpenGeoSys THM/C simulator version 5
https://www.opengeosys.org/ogs-5
Other
39 stars 97 forks source link

RFR reading #151

Open MuellerSeb opened 4 years ago

MuellerSeb commented 4 years ago

What is this var_n variable about? It is never used after setting.

https://github.com/ufz/ogs5/blob/e61a9ad538e4fdc5043e3a85bd06b2812760e7e8/FEM/rf_ic_new.cpp#L948

wenqing commented 4 years ago

@MuellerSeb You are right that the variable is defined but never used.

MuellerSeb commented 4 years ago

I speculate, that this was meant to deal with multi-valued variables, because this has a default value of 1 in all benchmarks.

Could there be any case with multiple values?!

I documented the assumed way: https://github.com/GeoStat-Framework/ogs5py/blob/f496dd528ca1559cb30aa19f4acf6d46edcbc6c5/ogs5py/fileclasses/ic/core.py#L138

wenqing commented 4 years ago

@MuellerSeb I guess that it is for multiple values but the implementation was not finished before. Instead of restart, you can use #RELOAD keyword.