Closed nagelt closed 8 years ago
@nagelt it looks you are still working on this. please remove WIP label when you finish it so that we can review it again
@norihiro-w I can't remove the label. Maybe I'm underprivileged ;-). Anyhow, I'm done changing things now, so go ahead and remove the label.
@bilke can you please add Thomas to the developer team?
@nagelt maybe it's more efficient if you use clang-format-diff to fix all indentation issues. don't forget to set style -style=file
@nagelt You should have the permissions to change labels now.
👍
@wenqing I've cleaned up the PR quite a bit and removed the output stuff for now.
:+1: , except for that in my last two comments.
@nagelt You can update the intput/output data of the benchmarks first.
@nagelt There is a memory leakage in ElementValue_DM::~ElementValue_DM()
when I run Newton/TH2M.
@wenqing could you check if the last commit fixed it? Otherwise I see no relevant change in ElementValue_DM::~ElementValue_DM() that would affect a linear elastic material.
@nagelt Strain = NULL does not fix the memory leakage.
@wenqing have you checked whether it occurs with the trunk also? All changes to this class are otherwise material model-specific I think.
I would like to keep Newton/TH2M, and I changed the NC file that makes the example be close to reality. In addition, I would like to keep the damping factor in the NR for the deformation analysis.
@nagelt the mater version works well. I sent two PRs to your PRs, one of which is about the input file changes, and the other is about recovery the damping factor.
@norihiro-w y esto
@nagelt UJG-M/m_sdc is still failing
@nagelt see Jenkins result. maybe the reference result has to be updated
@norihiro-w There's a pull-request open for that ..
sorry I missed it...
UJG-M/m_sdc is fixed now. But I realized now that WW-MPI/thm_quad/thm_quad is also failing due to time out. I think this is the last one to be fixed.
@nagelt please add OGS copyright header to the new source files and remove some old codes which you commented out, if there is no particular reason to keep them. then I think this PR is ready for being merged
This PR introduces two solid material models and tests. The changes introduced are confined to these specific material models.