norihiro-w
commented
8 years ago Two general comments so far
- Please apply clang-format-diff to format the source code. see https://github.com/ufz/ogs5/blob/master/CONTRIBUTING.md
- Some files are getting much longer. For readability, I think it's better to have separate cpp files (e.g. rf_pcs_BHE.cpp, fem_ele_std_BHE.cpp) for BHE features (without changing header files)
This pull request mainly contains the Borehole Heat Exchanger (BHE) feature. The following changes have been made in the code:
1) One more process is added, named as "HEAT_TRANSPORT_BHE". Its primary variable is "TEMPERATURE_SOIL", "TEMPERATURE_IN_1"(BHE inflow temp), "TEMPERATURE_OUT_1"(outflow temp), etc. So far only default RF linear solver is supported.
2) The soil is the 3D domain, while BHE is represented as 1D secondary domain. Details regarding the numerical algorithm can be found in the following two publications: http://dx.doi.org/10.1016/j.applthermaleng.2016.05.158 http://dx.doi.org/10.1016/j.applthermaleng.2016.02.039
3) The Boundary condition file was modified to impose special BHE boundary type. Most of the BHE parameters were read through the MMP file.
Further introduction of this new feature can be found in an up-comming OGS tutorial by Springer.