Fixed reload for stress data file under MPI

ufz / ogs5

OpenGeoSys THM/C simulator version 5

https://www.opengeosys.org/ogs-5

Other

39 stars 97 forks source link

Fixed reload for stress data file under MPI #76

Closed wenqing closed 7 years ago

wenqing commented 7 years ago

as titled.

norihiro-w commented 7 years ago

hi Wenqing, can you please check why Jenkins is failing?

norihiro-w commented 7 years ago

and it would be helpful if you can add a benchmark testing this.

wenqing commented 7 years ago

@norihiro-w Thanks for your comments.

It sounds a jenkins' script problem. @bilke Do you have time to check this?
I will try to add a test. Hope binary file input of the test will not cause a problem on Jenkins.

bilke commented 7 years ago

Yes, the Jenkins scripts aren't updated to a new syntax yet. I will fix that..

bilke commented 7 years ago

Should be fixed with #77.

wenqing commented 7 years ago

@bilke Thanks.

wenqing commented 7 years ago

@norihiro-w The test for this fixing would include two sub-tests for output and a test input (reload), respectively. Because the benchmarks may run in a random order, I am not sure the test would always work.

Since there is no such test for RELOAD in the sequential version either, I would like to merge this PR without a test. Anyway, I have already tested it with a benchmark of decovalex 2019.

norihiro-w commented 7 years ago

I think testing input is sufficient. If I remember it correctly, the test is already existing in some benchmark in the sequential version.

wenqing commented 7 years ago

@norihiro-w I will prepare test.

norihiro-w commented 7 years ago

thanks!

wenqing commented 7 years ago

@norihiro-w A test is added.

norihiro-w commented 7 years ago

thanks! if Jenkins is green, please merge it.