search

ufz / ogs5

OpenGeoSys THM/C simulator version 5
https://www.opengeosys.org/ogs-5
Other
39 stars 97 forks source link

Fixed a bug in face integration #91

Closed wenqing closed 6 years ago

wenqing commented 6 years ago

This PR fixes a bug in face integration for Neumann BC. If curved surface is applied with Neumann BC, the current code cannot compute the face integration correctly.

wenqing commented 6 years ago

@norihiro-w If you have time, please take a look. I have tested it by using a curved surface with a Neumann BC of 1. In the test, the sum of the computed node values by this PR is exactly the area of the curved surface.

norihiro-w commented 6 years ago

@wenqing ok. i will take a look

norihiro-w commented 6 years ago

Wenqing, are you assuming the elements are also curved? or you want to use a curve surface to find nodes of planar elements?

I mean that surface is curved, e.g. cylinder surface.

wenqing commented 6 years ago

Two benchmark reference files have been updated. For the reason, please see the description of PR ufz/ogs5-benchmarks_ref#21.

norihiro-w commented 6 years ago

@wenqing i'm ok if the benchmarking is green