uga-rosa / cmp-dictionary

A dictionary completion source for nvim-cmp
MIT License
236 stars 16 forks source link

documentation is not showing. Out of job.new is a list of strings, cmp expects a single string #61

Closed BerkeleyTrue closed 5 months ago

BerkeleyTrue commented 5 months ago

Hello,

I was updating cmp-dictionary to new v3 config. I noticed that 'documentation' was not showing in the cmp popup menu, but I could see results where returns in utils.system.

I went through cmp.nvim's source and it seems it expects item.dictionary to be a string or a table of value: string, kind: string. But the return from plenary.job:new was a list of strings, which cmp ignores.

I have a PR ready with a fix. It is a very simple fix that only modifies the logic under plenary.job condition of utils.system. I don't have vim.system so I am unable to test if that also returns a list of strings.