search

ugent-library / biblio-backoffice

Apache License 2.0
7 stars 0 forks source link

Inconsistency in "View Online" Button and PDF Attachment #1351

Closed mietcls closed 10 months ago

mietcls commented 10 months ago

Bug description

Inconsistency in "View Online" Button and PDF Attachment: Sometimes the "view online" button does not show up (via RBIB)

Description

All examples below have a PDF attached in Biblio:

Unexpected behaviour

"View online" button not showing for https://lib.ugent.be/catalog/pug01:01H2B16SDG99NAFC8XDWQQF4GZ screenshot_2023-12-22_at_09 46 26 This record has not been merged yet in the catalogue, it will be in the future with https://lib.ugent.be/en/catalog/pug01:01H2AGF5FKPQA9027Z75CS0C2W

Expected behaviour

"View online" button showing for https://lib.ugent.be/catalog/rug01:003164665 screenshot_2023-12-22_at_09 46 18 Other example, a pure, non-merged record: https://lib.ugent.be/catalog/pug01:01HF3QYKHC5TYHA525RCSYYKRY

Risk classification

Likelihood

How often does this happen? 4: Remote

Consequences

What's the impact? 4: Negligible

nicolasfranck commented 10 months ago

Cause: https://github.ugent.be/Universiteitsbibliotheek/lludss-import/blob/master/lib/Catmandu/Importer/Biblio.pm#L201

File are not considered if the classification is equal to B3 since https://github.ugent.be/Universiteitsbibliotheek/lludss-import/commit/0d95b6dc0e1c911c2618da8a05e33b645b35579c (2018). Not sure what that means

I asked @phochste , and here is what he answered:

ja, B3 is een junk categorie in Biblio..dat is de reden. Je weet daar nooit van te voren of de download echt het ding is wat het lib record beschrijft. Kan een volledig boek zijn, kan alleen een powerpoint zijn, dan alleen een inhoudsopgave zijn, kan alleen één hoofdstuk zijn. (edited) 3:12 PM dat is een vraag die elke 4 maanden opnieuw wordt gesteld, en elke 4 maanden is het antwoord hetzelfde: B3 zijn nog steeds junk records

nics commented 10 months ago

@phochste do you know why?

nicolasfranck commented 10 months ago

Related: https://github.com/ugent-library/biblio-backoffice/discussions/1199

mietcls commented 10 months ago

Closing for now, will create a new ticket if there is a solution available. One question, how is #1199 related?

nicolasfranck commented 10 months ago

@mietcls that issue is also about biblio records with classification B3. But there you another result: it is being labeled as "miscellaneous", for the same reason why the lib.ugent.be does not supply a download link: these records are labeled as "unclear what it is".