ugent-library / biblio-backoffice

Apache License 2.0
7 stars 0 forks source link

Metadata is sometimes hidden on search overview #1634

Closed mietcls closed 3 months ago

mietcls commented 3 months ago

Bug description

Metadata is sometimes hidden on search overview:

Steps to Reproduce

  1. Go to https://backoffice.bibliodev.ugent.be/publication
  2. Add a publication, and add departments to it. See no departments appear. Screenshot 2024-06-25 at 17 24 54
  3. Add a VABB year via batch. See no VABB year appear, nor departments.
  4. Add a dataset or check the "legacy" checkbox inside the publications details, see the departments and VABB appear: Screenshot 2024-06-25 at 17 26 32 Screenshot 2024-06-25 at 17 26 58

Expected behaviour

nicolasfranck commented 3 months ago

Culprit: https://github.com/ugent-library/biblio-backoffice/blob/dev/views/publication/summary/summary.templ#L165

The decision to either show the departments is wrapped within the decision to show one of legacy, vabb or related-dataset.

If departments are always part of this block (you can always show something), then there is no reason to remove this block based on a decision (line 165 can be removed), and copy it to https://github.com/ugent-library/biblio-backoffice/blob/dev/views/publication/summary/summary.templ#L185 where it belongs?