ugent-library / biblio-backoffice

Apache License 2.0
7 stars 0 forks source link

Publication/dataset detail page sidebar #1663

Open verheyenkoen opened 4 months ago

verheyenkoen commented 4 months ago

Enhancement

Add an icon sidebar on the right side in detail pages with 2 icons that open/toggle a drawer when clicked.

Prototype

mietcls commented 4 months ago

Added:

Suggestion for save: buttons for now until we have a coherent approach to saving everywhere (otherwise we will have different patterns which will be confusing).

Screenshot 2024-07-18 at 12 12 19

mietcls commented 4 months ago

Q: Can we remember whether the message tab was opened or closed by default?

verheyenkoen commented 4 months ago

Q: Can we remember whether the message tab was opened or closed by default?

verheyenkoen commented 2 months ago

@nics I started this a couple of weeks ago but very quickly bumped into the fact that this is needed for both publications and datasets so the question is: is there something we can do to make sure we don't have to build the sidebar twice? We talked about deduping other views but never took any steps AFAIK. I guess it would be good to finally kick this off before we create any new duplicate views.

nics commented 2 months ago

@verheyenkoen you can dedup them if it isn't too much work. The next version combines Publication and Dataset into Work, so it's not worth it duplicating all that effort here.

verheyenkoen commented 2 months ago

@nics I guess my question wasn't clear. How do we do that? I guess we need some kind of common structure for publications and datasets for that to be possible but I don't know how to achieve a base interface in Go that can be both. As I don't really know how this is done, I can't really estimate the effort for that.

nics commented 2 months ago

That was my point, making a common interface isn't worth the effort now, the next version already solves that. But if you can easily avoid some duplication now by making the url configurable and passing a common args to the template, then go ahead.

verheyenkoen commented 2 months ago

But I guess that requires mapping the common fields on a new struct type before passing it to the view?

verheyenkoen commented 2 months ago
  • Add a "dot" to Biblio messages menu item when there is a message added to the Biblio message field.

@nics Is this something we can achieve with the current Biblio? We can compare the message with previous snapshots but I don't think we have a way to log who has already seen this change (unless in local storage).

nics commented 2 months ago
  • Add a "dot" to Biblio messages menu item when there is a message added to the Biblio message field.

@nics Is this something we can achieve with the current Biblio? We can compare the message with previous snapshots but I don't think we have a way to log who has already seen this change (unless in local storage).

Not efficiently no, better to postpone this.

verheyenkoen commented 1 month ago

@mietcls I think we're gonna need some kind of loading-feedback when you click one of the save buttons. In the current version you see the popup close when the save is complete but in the sidebar, if the save succeeds nothing appears to be happening which may cause confusion.

mietcls commented 1 month ago

Thanks for noticing, I'll make something @verheyenkoen

mietcls commented 1 month ago

Discussion yesterday: Saving behaviour in the modals in the detail panel VS the save buttons in the side panel: might result into information loss.

@verheyenkoen can you confirm / add any thoughts?