ugent-library / biblio-backoffice

Apache License 2.0
7 stars 0 forks source link

improve project search #289

Closed sdebodt closed 2 years ago

sdebodt commented 2 years ago

Describe the improvement To identify a relevant project, a search needs to be done in the Add project pop up. Sometimes, the search results are not correct.

"agriculture in": no results (screenshot 1) "agriculture in Europe": 2 results (screenshot 2)

Can partial text matching be added? Otherwise the user needs to know the exact word or combination of words, which would mean that he would probably needs to search ResearchExplorer/GISMO first.

Screenshots image image

nicolasfranck commented 2 years ago

@sdebodt the examples you provided are not the result of lack of partial text matching, at least at first sight. Partial text matching is more like "agri" that should match "agriculture". If nothing matches for "agriculture", then there is something wrong with that index.

nicolasfranck commented 2 years ago
template: layouts/htmx:7:2: executing "layouts/htmx" at <yield>: error calling yield: template: publication/projects/_modal_hits:17:40: executing "publication/projects/_modal_hits" at <pathFor "publication_projects_add_to_publication" "id" $.D.Publication.ID "project_id" $hit.ID>: error calling pathFor: mux: variable "PL_ERA_IP_6_2008/6/2008" doesn't match, expected "^[^/]+$"

Results are found, but biblio-backend breaks on their identifiers when they contain forward slashes

sdebodt commented 2 years ago

Indeed, the partial text match is something that I would implement in addition to the fix for the example that I showed where using two words gives a different result than using three words of the project title.

nics commented 2 years ago
sdebodt commented 2 years ago

It seems that too many results are now returned...

image

nics commented 2 years ago

also known id search returns results with other ids

nics commented 2 years ago

@nicolasfranck can you take a look?

nics commented 2 years ago

fixed by https://github.ugent.be/Universiteitsbibliotheek/librecat