ugent-library / biblio-backoffice

Apache License 2.0
7 stars 0 forks source link

Move "Librarian record message" to researchers to "Messages" (AKA "Biblio activity") tab #516

Closed mietcls closed 2 years ago

mietcls commented 2 years ago

Story

As a librarian, I can add a librarian message to communicate with researchers (and other librarians). Currently it's located in the record details page, but it should go to the activity tab.

Full story on epic https://github.com/ugent-library/biblio-backend/issues/512

Success criteria

Visibility

Implementation

Design

Overview

Available in the "Biblio activity" tab: Librarian record message (on the right) Image

Adding and removing a message

Example code

Overview (with librarian message)

<div class="row">
  <div class="col-lg-6">
    <div class="card mb-6">
      <div class="card-header">
        <div class="bc-toolbar">
          <div class="bc-toolbar-left">
            <h3 class="card-title">Librarian tags</h3>
          </div>
          <div class="bc-toolbar-right">
            <button class="btn btn-outline-primary" type="button" data-toggle="modal" data-target="#editTags">
              <i class="if if-edit"></I>
              <div class="btn-text">Edit</div>
            </button>
          </div>
        </div>
      </div>
      <div class="card-body">
        <div class="badge-list">
          <a class="badge badge-secondary" href="/biblio/reviewer/publications/overview.html">funding to do: belgium</a>
          <a class="badge badge-secondary" href="/biblio/reviewer/publications/overview.html">group author publication</a>
          <a class="badge badge-secondary" href="/biblio/reviewer/publications/overview.html">funding to do: cost</a>
          <a class="badge badge-secondary" href="/biblio/reviewer/publications/overview.html">cc-by-2.0</a>
        </div>
      </div>
    </div>
  </div>
  <div class="col-lg-6">
    <div class="card mb-6">
      <div class="card-header">
        <div class="bc-toolbar">
          <div class="bc-toolbar-left">
            <h3 class="card-title">Librarian note</h3>
          </div>
        </div>
      </div>
      <div class="card-body">
        <textarea class="form-control" placeholder="" rows="4"></textarea><p><small class="form-text text-muted">Add internal notes here.</small></p>
      </div>
    </div>
  </div>
</div>

Context

Old back-end

Typing Image

Viewing Image

nics commented 2 years ago

@mietcls can this be closed? it's not super efficient now, with edit and save buttons, but it works

mietcls commented 2 years ago

@nics I just tested it, the above checks are correct but I noticed researchers can't edit the message (forgot to add that check).

Result when I click edit: Schermafbeelding 2022-09-06 om 16 31 04

Do I create a new issue so you can close this one?

nics commented 2 years ago

@mietcls there was an edit button even if you didn't have rights to edit the record, should be ok now

mietcls commented 2 years ago

@nics I can't see the edit button anymore, but I'll close this issue because the gist works and create a new one for this specific part – as it was not one of the success criteria here: https://github.com/ugent-library/biblio-backend/issues/573